Repository navigation
fix(attributes): Apply consistent scrubbing across deprecations - #692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
| "key": "manual", | ||
| "reason": "Tool results can contain user data" |
There was a problem hiding this comment.
How come we align on the weaker setting for attributes that can contain user data? Or is the reason text incorrect?
There was a problem hiding this comment.
@elramen I'm trying to avoid user-visible changes. We prioritize the latest version of attributes in the product, so effectively, that's the scrubbing rule we're applying - so I took the latest rule and applied it to the older deprecated aliases.
There was a problem hiding this comment.
Good catch, thanks for cleaning this up! The changes from auto to manual look reasonable to me for non-gen_ai attributes. For the gen_ai ones, I'd appreciate a second pair of eyes from agent tracing folks if the policies of the current attributes are intentional, since some of them seem a bit more "risky".
|
@Lms24 Thanks! Looks like @obostjancic okay'd this on Slack, so I'm going to go ahead. We were already prioritizing the latest version of attributes in Sentry which would have had the weaker scrubbing rules already, so this isn't effectively weakening anything IMO. |
|
I think this just needs another update since we merged some PRs around the same time. Gonna rebase, then this should auto merge |
Description
Apply the same scrubbing rules across entire deprecation chains. This keeps the scrubbing behaviour predictable whether or not Relay is doing attribute rewriting. It also make semantic sense - if two attributes have identical semantic meanings, they should also have identical scrubbing rules.
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.