Skip to content

fix(attributes): Remove any as valid attribute type #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into from
Oct 6, 2026
Merged

fix(attributes): Remove any as valid attribute type #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c341b5
fix(attributes): Remove `any` as valid attribute type
Lms24 Oct 6, 2026
d372b91
Merge branch 'main' into lms/fix-remove-any
Lms24 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schemas/attribute.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"type": {
"description": "The type of the attribute value",
"enum": ["string", "boolean", "integer", "double", "string[]", "boolean[]", "integer[]", "double[]", "any"]
"enum": ["string", "boolean", "integer", "double", "string[]", "boolean[]", "integer[]", "double[]"]

@cursor cursor Bot Oct 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover any type branch

Low Severity

Removing any from the type enum leaves an unreachable oneOf branch that still matches const: "any". That branch can never validate now and is leftover from the previous iteration this change is cleaning up.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d372b91. Configure here.

},
"apply_scrubbing": {
"description": "How PII scrubbing should be applied to the attribute value. 'auto' scrubs automatically, 'manual' requires manual scrubbing rules, 'never' is never scrubbed. Optionally include a reason about why this mode applies",
Expand Down
Loading