fix: Screenshots not being captured by hybrid SDKs

[antonis]

📜 Description

SentryDependencyContainer.screenshotSource was a lazy var wrapping getOptionalLazyVar. getOptionalLazyVar is designed to retry its builder until the value can be produced, but the lazy var defeats that: it runs the initializer once and caches whatever the first access returned. The builder returns nil when startOptions isn't set yet, so if screenshotSource is first read before the SDK is started, that nil gets cached permanently and no screenshot can be captured for the rest of the process.

This changes screenshotSource from a lazy var to a computed property so getOptionalLazyVar re-runs the builder until startOptions is available, then caches the built source. The setter is kept (a lazy var was settable, and tests inject a mock source). Adds a regression test.

💡 Motivation and Context

Hybrid SDKs touch SentrySDK.internal before SentrySDK.start (e.g. React Native reads SDK metadata / app-start data during init). Constructing SentrySDK.internal eagerly reads screenshotSource, which poisoned the lazy var and broke all screenshot capture on iOS — Feedback Widget screenshots, attachScreenshot, and SentrySDK.internal.screenshot.capture(). This shipped as a regression in sentry-react-native 8.19.0.

This is the sentry-cocoa fix tracked by getsentry/sentry-react-native#6507**.** That issue reverted the RN migration (getsentry/sentry-react-native#6380) as an interim fix; once this cocoa change ships and RN bumps the cocoa dependency, the RN migration will be reapplied.

• Original RN regression report: iOS: screenshots no longer captured since 8.19.0 (Feedback Widget, attachScreenshot, captureScreenshot) sentry-react-native#6497
• Tracking / reapply follow-up: Reapply iOS SentrySDK.internal migration (#6380) after sentry-cocoa fixes screenshotSource lazy-var poisoning sentry-react-native#6507

💚 How did you test it?

Added testScreenshotSource_AccessedBeforeStartOptions_RebuildsAfterStart, which reproduces the sequence: read screenshotSource before startOptions is set (→ nil, and must not be cached), set options, then assert it's rebuilt (non-nil). It fails on the old lazy var and passes with the fix.

Ran on the iOS 18.6 simulator across SentryDependencyContainerTests, SentryScreenshotIntegrationTests, SentryScreenshotSourceTests, and UserFeedbackIntegrationTests — all passing.

📝 Checklist

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.
• Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
• If I added a new public API, I also added it to the SentryObjC wrapper.

🤖 Generated with Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a023a20. Configure here.}

[sentry]

📲 Install Builds

iOS

🔗 App Name	App ID	Version	Configuration
SDK-Size	io.sentry.sample.SDK-Size	9.23.0 (1)	Release

⚙️ sentry-cocoa Build Distribution Settings

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1229.41 ms	1258.51 ms	29.10 ms
Size	24.14 KiB	1.25 MiB	1.23 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
ce33dcf	1236.42 ms	1267.76 ms	31.34 ms
0a8fa8a	1230.72 ms	1261.64 ms	30.91 ms
4455127	1216.29 ms	1250.00 ms	33.71 ms
4e7765a	1230.37 ms	1265.84 ms	35.47 ms
b557385	1211.45 ms	1252.67 ms	41.22 ms
3efa7b5	1226.55 ms	1260.66 ms	34.11 ms
0303c4f	1229.73 ms	1264.79 ms	35.06 ms
8469478	1240.30 ms	1277.07 ms	36.76 ms
bbc91e5	1215.94 ms	1243.26 ms	27.32 ms
5bcf269	1223.60 ms	1245.49 ms	21.89 ms

App size

Revision	Plain	With Sentry	Diff
ce33dcf	24.14 KiB	1.19 MiB	1.16 MiB
0a8fa8a	24.14 KiB	1.18 MiB	1.15 MiB
4455127	24.14 KiB	1.24 MiB	1.21 MiB
4e7765a	24.14 KiB	1.24 MiB	1.22 MiB
b557385	24.14 KiB	1.23 MiB	1.20 MiB
3efa7b5	24.14 KiB	1.22 MiB	1.19 MiB
0303c4f	24.14 KiB	1.24 MiB	1.21 MiB
8469478	24.14 KiB	1.24 MiB	1.21 MiB
bbc91e5	24.14 KiB	1.17 MiB	1.14 MiB
5bcf269	24.14 KiB	1.17 MiB	1.15 MiB

[github-actions]

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Screenshots not being captured by hybrid SDKs ([#8578](https://github.com/getsentry/sentry-cocoa/pull/8578))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against a023a20