fix: Ensure URL and Auth Token come from same source#3382
fix: Ensure URL and Auth Token come from same source#3382szokeasaurusrex wants to merge 1 commit into
Conversation
b11a883 to
cf396ff
Compare
Backport of #3378 to v2
cf396ff to
03dd68f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 03dd68f. Configure here.
| Some(DiscardedAuthUrlValue::Auth) => { | ||
| base.delete_from(Some("auth"), "token"); | ||
| base.delete_from(Some("auth"), "api_key"); | ||
| } |
There was a problem hiding this comment.
Login skips token overwrite warning
Low Severity
merge_config_source deletes inherited auth from the in-memory INI when a higher-priority file provides only a URL. login then uses get_persisted_auth, so an on-disk token in the save target can be overwritten without the org-mismatch warning. Runtime discards correctly leave the INI alone; file merges do not.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 03dd68f. Configure here.
There was a problem hiding this comment.
This seems like a pretty rare edge case; I think it is probably not worth fixing here, but we can reconsider
1 participant
Backport of #3378 to v2