Repository navigation
Conversation
Android 17's ART writes five new keys in the `*version` header of method traces (`is_streaming`, `is_precise_trace`, `end_time`, `end_tsc`, `compilation-filter`). `android_trace_log` rejects unknown header keys, so these profiles were dropped as `profiling_invalid_sampled_profile`. Remove exactly these header lines before parsing, for both legacy transaction profiles and Android trace chunks. Other unknown keys are still rejected. Fixes #6517 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5b162ac. Configure here.
antonis
marked this pull request as ready for review
October 16, 2026 12:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android method traces recorded on Android 17 (API 37) are currently dropped with
profiling_invalid_sampled_profile. Android 17's ART writes five new keys in the*versionheader of every method trace (is_streaming,is_precise_trace,end_time,end_tsc,compilation-filter, seeTraceWriter::CreateSummaryinruntime/trace.cconandroid17-release).android_trace_log0.3.0 rejects any header key it does not know, so the whole profile fails to parse.This PR removes exactly these five header lines before handing the trace to
android_trace_log, for both transaction profiles (legacy.rs) and Android trace chunks (chunk.rs).*versionsection is touched. The binary data section is copied as is, and itsdata_offsetis relative to theSLOWmagic, so shortening the text header does not move it.Alternative considered: skip all unknown header keys
Instead of listing the five Android 17 keys, we could skip every header key that
android_trace_logdoes not know. That would keep future Android versions from breaking. We went with the explicit list to stay conservative and keep the change minimal.Context
Fixes #6517
Testing