Repository navigation
Conversation
This was referenced Oct 7, 2026
betegon
force-pushed
the
bt/mcp-conventions-normalization
branch
from
October 13, 2026 08:47
6732f00 to
2584cdc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression coverage for the MCP normalization behavior provided by sentry-conventions 0.27.0, adopted in #6498.
Before that conventions update,
mcp.transport=CustomHTTPTransportcould fabricatenetwork.transport=CustomHTTPTransport, andmcp.resource.protocol=filecould preventnet.protocol.name=httpfrom backfilling the real network protocol. The tests now verify that MCP implementation names and resource schemes remain separate from network attributes, both with and without network metadata.This PR only adds the two normalizer tests; the conventions bump is already on
masterthrough #6498.Validation: all 865
relay-event-normalizationtests and seven doctests pass with all features enabled; package clippy with warnings denied and workspace formatting checks pass.#skip-changelog