Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request extends Dozer streaming SQL
IN/NOT INlist evaluation with full SQL three-valued logic and NULL semantics, resolving #1659.Key Changes
dozer-sql/expression/src/in_list.rs:INandNOT INpredicates:exprevaluates toNULL, returnsField::Null.Field::Boolean(true)immediately regardless of whetherNULLvalues exist elsewhere in the list.NULLitems, returnsField::Null(Unknown).NULLs, returnsField::Boolean(false).NOT IN):NOT (true)->false,NOT (false)->true,NOT (null)->null.dozer-sql/src/expression/tests/in_list.rs:test_in_list_with_nullscovering all 12 permutations:42 IN (NULL)->Field::Null42 IN (1, NULL)->Field::Null42 IN (1, NULL, 42)->Field::Boolean(true)42 NOT IN (1, NULL)->Field::NullNULL IN (1, 2, 3)->Field::Null42 NOT IN (1, 2, 3)->Field::Boolean(true)42 NOT IN (1, 2, 3, 42)->Field::Boolean(false)42 NOT IN (1, 2, 3, 42, NULL)->Field::Boolean(false)Verification
All 215 tests in
dozer-sqland 27 tests indozer-sql-expressionpass cleanly:/claim #1659
Resolves #1659
Payout Wallet (Base L2):
0x46D5318E4397cFcBED06a235c1604E473682Ea1F