Remove the transcode plugins and the vendored sse2neon.h - #176
Merged
Conversation
Transcode has not seen a release in over a decade and its download links in Install pointed at berlios, which shut down in 2014. The three plugins could not have been built by anyone for years without first finding a transcode source tree, and nothing here was testing them. sse2neon.h went unused when ARM gained native NEON kernels: nothing includes it, and the SIMD dispatch reaches motiondetect_neon.c directly through arm_neon.h. It was 9200 lines of vendored third party code carried for nobody, and the only MIT licensed file in the tree. src/vid.stab.prj goes with them -- a project file from the transcode era that lists filter_stabilize.c, libdeshake.c and dslist.c, none of which have existed for years. The library, the tests and the ffmpeg filters are untouched: 35/35 unit tests pass. References in README, Install and the build files are updated; the licence headers of the five files that came from transcode still name it, and are left for the relicensing change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-targeted at
master. #175 was merged intochore/msvc-portability— a branch that had already been merged by #171 — so this change never reachedmaster. Same commit, rebased onto currentmaster; a merged PR cannot be reopened against a different base, hence the new number.Drops two things nobody can be using.
transcode/— transcode has had no release in over a decade, and the download links inInstallpointed at berlios, which shut down in 2014. Building the three plugins required finding a transcode source tree first and pointingTRANSCODE_ROOTat it by hand; nothing in CI ever built them.src/sse2neon.h— 9200 lines of vendored third-party code that nothing includes. ARM is served by native NEON kernels inmotiondetect_neon.cviaarm_neon.h; the shim went unused in the SIMD dispatch rework, asdocs/superpowers/simd-optimization-report.mdalready noted.src/vid.stab.prj— a project file from the transcode era listingfilter_stabilize.c,libdeshake.canddslist.c, none of which have existed for years.Also updated:
README.md,Installand the stale include comment intests/CMakeLists.txt, plus the commented-outinclude (sse2neon)inCMakeLists.txt. The licence headers of the fivesrc/files that originated in transcode still name it; those are normalised by the relicensing change in #174.Verified on the rebased result, not on the earlier branch point: shared build clean, static build clean, and 36/36 unit tests pass — including under
VIDSTAB_SIMD=noneandVIDSTAB_SIMD=sse2. The rebase needed one resolution, inChangelog, where #172's entry and this one both sit at the top of the 1.3 block; both are kept.🤖 Generated with Claude Code