hackage status: --updates option to show atoms that present both in overlay and hackage - #147
Open
Miezhiko wants to merge 1 commit into
Open
hackage status: --updates option to show atoms that present both in overlay and hackage#147Miezhiko wants to merge 1 commit into
Miezhiko wants to merge 1 commit into
Conversation
…verlay and hackage Signed-off-by: Miezhiko <Miezhiko@gmail.com>
hololeap
requested changes
Mar 20, 2026
hololeap
left a comment
hololeap
left a comment
Member
There was a problem hiding this comment.
This looks good. The only criticism I have is to make the help text a bit more clear.
| <> Opt.help "Print only packages likely to be interesting to move from hackage tree." | ||
| , Opt.flag' OverlayAndHackage | ||
| $ Opt.long "updates" | ||
| <> Opt.help "Print only packages that present in both overlay and tree (overlay)." |
Member
There was a problem hiding this comment.
Suggested change
| <> Opt.help "Print only packages that present in both overlay and tree (overlay)." | |
| <> Opt.help "Print only packages that are present in the local Haskell repo (overlay) and have new versions on Hackage." |
hololeap
reviewed
Mar 20, 2026
| $ Opt.long "from-hackage" | ||
| <> Opt.help "Print only packages likely to be interesting to move from hackage tree." | ||
| , Opt.flag' OverlayAndHackage | ||
| $ Opt.long "updates" |
Member
There was a problem hiding this comment.
Consider changing the option to --repo-updates, or anything that implies these are only updates for the local Haskell repo, not ::gentoo/portage.
hololeap
reviewed
Mar 20, 2026
| overlayAndHackageFilter :: Map PackageName [FileStatus ExistingEbuild] -> Map PackageName [FileStatus ExistingEbuild] | ||
| overlayAndHackageFilter = Map.filter $ \sts -> | ||
| let hasOverlay = any (\st -> case st of { OverlayOnly _ -> True; Same _ -> True; Differs _ _ -> True; _ -> False }) sts | ||
| hasHackage = any (\st -> case st of { HackageOnly _ -> True; _ -> False }) sts |
Member
There was a problem hiding this comment.
Something else I thought of: does matching on HackageOnly only match newer versions or will it also match older versions that are not in our local Haskell repo? This is something we can address later if it turns out to be a problem.
(This really depends on how the Map was generated, which I am not familiar with.)
Contributor
Author
|
thanks for review, I will check for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helpful to check for updates
gentoo-haskell/gentoo-haskell#1559 (comment)