Skip to content

fix(control): screen recordings are private: the segment folder and the recordings folder are owner only - #597

Merged
genesiscz merged 1 commit into
masterfrom
fix/2026-10-26-private-recordings
Oct 26, 2026
Merged

genesiscz merged 1 commit into
masterfrom
fix/2026-10-26-private-recordings

Conversation

@genesiscz

Copy link
Copy Markdown
Owner

Why

A review of #562 found that a screen recording session created its segment folder with default permissions. With the usual 022 umask the folder is 0755, so another local user can list and read the raw recording segments. The default output movie lands in the shared recordings folder, which was not private either.

What changes

  • RecordingSession.start() creates the segment folder with mode 0700 and runs chmod 0700, because mkdir's mode does not change a folder that already exists.
  • tools control capture-session makes the recordings folder (~/.genesis-tools/control/recordings) owner only before it starts, so the default output movie and every session folder inside it are private.
  • A user-chosen --output path keeps its own folder's permissions.

Tests

  • New test: the segment folder is 0700 both when the session creates it and when it already exists as 0755.
  • Negative control: without the recording-session.ts change the new test fails (24 pass, 1 fail); with it, src/control passes (146 pass, 0 fail).

…ent folder and the recordings folder are created owner only
@eve-bot-lovinka

eve-bot-lovinka Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🐉 eve review — ✅ APPROVE · 0 findings

→ review · run

  • Queued 05:24:00Z
  • Reading diff — 3 files
  • Building repo map
  • Analyzing (find → verify) — 0 candidates → 0 survivors · reviewed by codex/gpt-6.1-sol
  • Posting review
  • Review posted 05:28:23Z (4m 23s)

run wrun_01M5VAPJ5F7MG5NTP7DS7ZYM4R

Previous runs (1)
run head outcome findings took
1 930b903 ⏳ refused — 4m 7s

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between f010b18 and 930b903.

Files selected for processing: 3
  • src/control/commands/capture-session.ts
  • src/control/lib/recording-session.test.ts
  • src/control/lib/recording-session.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@eve-bot-lovinka eve-bot-lovinka Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐉 eve review — ✅ Approved

930b903 · 0 actionable findings · reviewed by codex/gpt-6.1-sol · view run ↗

ℹ️ Claims vs diff — 5 claims could not be checked from the diff (c1, c2, c3, c4, c5).

@genesiscz
genesiscz merged commit 930b903 into master Oct 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant