Repository navigation
fix(control): screen recordings are private: the segment folder and the recordings folder are owner only - #597
Conversation
…ent folder and the recordings folder are created owner only
|
🐉 eve review — ✅ APPROVE · 0 findings
run Previous runs (1)
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 4 minutes. View limit details
Comment |
There was a problem hiding this comment.
🐉 eve review — ✅ Approved
930b903· 0 actionable findings · reviewed by codex/gpt-6.1-sol · view run ↗
ℹ️ Claims vs diff — 5 claims could not be checked from the diff (c1, c2, c3, c4, c5).
Why
A review of #562 found that a screen recording session created its segment folder with default permissions. With the usual 022 umask the folder is 0755, so another local user can list and read the raw recording segments. The default output movie lands in the shared recordings folder, which was not private either.
What changes
RecordingSession.start()creates the segment folder with mode 0700 and runschmod 0700, becausemkdir's mode does not change a folder that already exists.tools control capture-sessionmakes the recordings folder (~/.genesis-tools/control/recordings) owner only before it starts, so the default output movie and every session folder inside it are private.--outputpath keeps its own folder's permissions.Tests
recording-session.tschange the new test fails (24 pass, 1 fail); with it,src/controlpasses (146 pass, 0 fail).