Repository navigation
feat(codex, babysit): review runs take a base and a tier contract, and tools codex reviews lists and imports the review ledger - #592
Conversation
|
🐉 eve review — ⏭️ superseded → run
run Previous runs (1)
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 8 minutes. View limit details
Comment |
There was a problem hiding this comment.
🐉 eve review — 🟡 Review comments
35d67b9· 4 actionable findings · reviewed by find codex/gpt-6.1-sol + codex/gpt-6-luna, verify codex/gpt-6-luna · view run ↗
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
ℹ️ Checks (advisory — CI is authoritative) — typecheck timed out (tsconfig.json): out of memory, then its 6144 MiB retry ran out of time
Blast radius
codexDriver(~) → 7 dependent(s) outside this PR: src/codex/lib/message-delivery.ts, src/codex/commands/queue.ts, src/codex/lib/spec.tsbuildWorkerContract(~) → 4 dependent(s) outside this PR: src/grok/lib/worker.ts, src/claude/lib/worker/worker.ts- 78 compiler diagnostic(s) on the PR head touch this diff (graph truncated)
ℹ️ Claims vs diff — 5 claims could not be checked from the diff (c1, c5, c6, c7, c8).
…an import recovers the historical base and head, and live ledger writes survive a torn line
Review fixes 2026-10-26 02:08 from GPT-6.1 Sol judged by Claude Opus 5.5 (fable-judge)Round 1. 4 open threads (eve 4, CodeRabbit 0). All 4 findings are valid and have uncommitted fixes, along with 1 self-review finding. No findings were rejected or deferred. Fixed in 86c8f7f. Recover the historical base and head before importing coverage (eve-bot-lovinka)
Record explicit PR identity for detached reviews (eve-bot-lovinka)
Use torn-line recovery for live ledger writes (eve-bot-lovinka)
Pin the range used by manifests and review contracts (eve-bot-lovinka)
Apply the live gate's binary exemption before declaring imported coverage shallow (self-review, no thread)
Threads: t1 accepted · t2 accepted · t3 accepted · t4 accepted |
… review's effort from the diff size (high, xhigh above about 50 files), because medium reviews were measured shallow
…ock and the diff manifest, so a reviewer on any backend gets the same depth rules and output shape
…est and the tier contract, picks the tier from the diff size, and gates the depth after each turn (one steer, one rerun a tier higher, then shallow), logging every turn and decision to the review ledger
…er with filters and totals, and review-depth shows one review's coverage, reasoning per 100 lines and gate history
…-base and leave depth to its contract and gate, and both skills name tools codex reviews; plugin 1.0.116
…rom sessions that ran before it, with the verdict their coverage line implies and a manifest up to the commit the review saw
…e its table already prints the result
…s and spaces in paths and fails a named unread file, records each check for review-depth, which reads only the current run, an import fails loudly and redoes a partial one, and the review spawn line quotes every value
…line starts on its own line, so a redone import never folds the old batch's turns into its row
…an import recovers the historical base and head, and live ledger writes survive a torn line
86c8f7f to
2b6bdbb
Compare
Codex review runs get a base and a tier contract:
spawn --mode review --baseinjects the diff manifest and picks high or xhigh from the diff size;tools codex reviewslists every run from the review ledger (andimportbackfills it); the review gate keeps paths with underscores and spaces; a ledger append after a torn line starts on its own line. The babysit and handoff-to skills document it.Gates on this branch (clean worktree, 2026-10-25):
bun scripts/git/check-commits.ts, roottsc --noEmit, biome on the changed files, the related tests, andscripts/ci/placeholder-check.sh. Tests: 7 files, 108 pass.Split out of the unified branch (#507); each commit is a cherry-pick of its unified original. Two text conflicts with master's 7e40b01 were merged by hand: babysit SKILL.md 7a keeps master's policy (a review when the user asks, no minimum round count) and adds the spawn mechanics; the review-brief.ts header keeps master's first sentence and adds the printed spawn line.