Repository navigation
fix(gitlab, prs): a review is signed by $GENESIS_TOOLS_AGENT, and a GitLab MR with more than 100 commits opens again - #590
Conversation
|
🐉 eve review — ⏭️ superseded → run
run Previous runs (1)
|
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 9 minutes. View limit details
Comment |
There was a problem hiding this comment.
🐉 eve review — 🟡 Review comments
4d92285· 1 actionable finding · reviewed by find codex/gpt-6.1-sol + codex/gpt-6-luna, verify codex/gpt-6-luna · view run ↗
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
ℹ️ Checks (advisory — CI is authoritative) — typecheck timed out (tsconfig.json): out of memory, then its 6144 MiB retry ran out of time
Blast radius
env(~) → 12 dependent(s) outside this PR: src/utils/env/index.ts, src/utils/process/spawnDashboard.ts, src/utils/agent/runtime.ts, +5 moreregisterCommentsPost(~) → 4 dependent(s) outside this PR: src/gitlab/commands/pr.ts, src/gitlab/commands/review-commands.test.tsregisterReviewJudgements(~) → 4 dependent(s) outside this PR: src/gitlab/commands/pr.ts, src/gitlab/commands/review-commands.test.tsregisterPrReview(~) → 2 dependent(s) outside this PR: src/gitlab/commands/pr.tsGitLabUser(Δsig) → 1 dependent(s) outside this PR: src/gitlab/commands/analyze-user.tsparseGlabMrView(~) → 1 dependent(s) outside this PR: src/utils/git/origins/index.ts- graph truncated by caps — dependents above are a lower bound
ℹ️ Claims vs diff — 1 claim could not be checked from the diff (c4).
Review fixes 2026-10-26 02:07 from GPT-6.1 Sol judged by Claude Opus 5.5 (fable-judge)Round 1. 1 open thread (eve 1, CodeRabbit 0). 1 fixed, 0 rejected, 0 already done. Full PR self-review found no additional defects. Test verification: not run (the lead verifies at integration). Reject unconsumed text outside JSON documents (eve-bot-lovinka)
Threads: t1 accepted |
… is not given, so a Fable or Codex session names itself, and the /user type carries email and commit_email
…ain, since glab --paginate prints one JSON array per page back to back and the commits are now read page by page
0b86c7a to
326b858
Compare
Two GitLab fixes: a review is signed by
$GENESIS_TOOLS_AGENTwhen--agentis not given, so a Fable or Codex session names itself; and a GitLab MR with more than 100 commits opens again, sinceglab --paginateprints one JSON array per page and they are now joined.Gates on this branch (clean worktree, 2026-10-25):
bun scripts/git/check-commits.ts, roottsc --noEmit, biome on the changed files, the related tests, andscripts/ci/placeholder-check.sh. Tests: 5 files, 177 pass.Split out of the unified branch (#507); each commit is a cherry-pick of its unified original. The third commit planned here (16b92bb, a link's range that ends in unpushed commits) is left out: master's newer
PRLinkedRangeAPI (7e40b01) changed under it, so it needs a port and comes in its own PR.