Repository navigation
feat(GenesisKit): Claude, Codex and Grok show their marks instead of letters everywhere, drawn by one AIProviderMark - #589
Conversation
|
🐉 eve review — ✅ APPROVE · 1 finding
run Previous runs (2)
|
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
![eve-bot-lovinka[bot]](https://avatars.githubusercontent.com/in/4092731?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐉 eve review — ✅ Approved
0b286c7· 0 actionable findings · reviewed by codex/gpt-6.1-sol + codex/gpt-6-luna · view run ↗
Blast radius
path(+) → 4 dependent(s) outside this PR: native/ax-tool/Tests/ClipboardPasteTests.swift, native/ax-tool/Tests/PermissionRefusalTests.swift, native/ax-tool/Tests/SnapshotDispatchTests.swift, +1 moreaddArc(+) → 3 dependent(s) outside this PR: src/macos/GenesisKit/Sources/GenesisKit/Controls/SpinningArc.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/SegmentedDonut.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/SunburstChart.swiftangle(+) → 3 dependent(s) outside this PR: native/ax-tool/Sources/CursorOverlay.swift, src/macos/GenesisKit/Tests/GenesisKitTests/KitChartsTests.swift, src/macos/GenesisKit/Sources/GenesisKitPosture/Posture/PostureAlert.swift- graph truncated by caps — dependents above are a lower bound
ℹ️ Claims vs diff — 3 claims could not be checked from the diff (c1, c4, c5).
There was a problem hiding this comment.
🐉 eve review — ✅ Approved
19506dc· 0 actionable findings · reviewed by codex/gpt-6.1-sol + codex/gpt-6-luna · view run ↗
Review fixes 2026-10-26 01:45 from GPT-6.1 Sol judged by Claude Opus 5.5 (fable-judge)Round 1. 0 open threads (eve 0, CodeRabbit 0, humans 0). The supplied review bodies and PR comments contain no actionable findings. This round was a self-review of all 14 changed files; no concrete defects found. No source changes or commit were needed. Swift verification: not run (lead runs the tests at integration), including ForgeBadgeTests. Before the lead prohibited tests and typechecks, TypeScript typecheck passed and the domains suite completed with 53 passing tests and one server-listen failure (EADDRINUSE at port 0), before the request-size assertion. No further tests or typechecks were run. Biome, lint:rules and check-tool-commands passed. |
…letters everywhere, drawn by one AIProviderMark behind AIProviderGlyph, ProviderBadge and the transcript avatar, with SVG arcs in the path parser
… tree, search and git tests, and a plain-word IDN sample
19506dc to
5487de7
Compare
There was a problem hiding this comment.
🐉 eve review — ✅ Approved
5487de7· 1 actionable finding · reviewed by find codex/gpt-6.1-sol + codex/gpt-6-luna, verify codex/gpt-6-luna · view run ↗
| Severity | Count |
|---|---|
| 🔵 Low | 1 |
Blast radius
angle(+) → 5 dependent(s) outside this PR: native/ax-tool/Sources/CursorOverlay.swift, src/macos/GenesisTools/scripts/build-icon.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/SegmentedDonut.swift, +2 moreaddArc(+) → 3 dependent(s) outside this PR: src/macos/GenesisKit/Sources/GenesisKitCharts/SegmentedDonut.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/SunburstChart.swift, src/macos/GenesisKit/Sources/GenesisKit/Controls/SpinningArc.swiftpath(+) → 2 dependent(s) outside this PR: native/ax-tool/Sources/AppLifecycle.swift, native/ax-tool/Sources/commands/Annotate.swift- graph truncated by caps — dependents above are a lower bound
ℹ️ Claims vs diff — 4 claims could not be checked from the diff (c1, c2, c4, c5).
| public var style: AIProviderGlyphStyle | ||
|
|
||
| public init(meta: AIProviderMeta, size: CGFloat = 16) { | ||
| public init(meta: AIProviderMeta, size: CGFloat = 16, style: AIProviderGlyphStyle = .tinted) { |
There was a problem hiding this comment.
📝 Docs | 🔵 Low · confidence 85/100
Update the provider API guide for marks and glyph styles
The public provider guide in src/macos/GenesisKit/README.md:6636 and 6674–6679 still describes AIProviderGlyph as a one-letter tinted box and documents only meta and size (including the old letter-size ratio). This change replaces that behavior and adds the public style parameter, AIProviderGlyphStyle, and AIProviderMark, none of which the guide explains. Update the Providers section to describe known-provider marks, unknown-provider letter fallback, and the tinted/plain/filled styles so consumers can discover and correctly use the new public surface.
🧩 Analysis
Grep evidence: one-letter tinted box|one-letter glyph in a box|letter is 62.5|public enum AIProviderGlyphStyle
There was a problem hiding this comment.
Accepted. The follow-up will update the provider API guide for marks and glyph styles. The pull request was merged after its fix rounds, so this finding waits for a follow-up, and this thread stays open until then.
Claude, Codex and Grok show their marks instead of letters everywhere in GenesisKit, drawn by one
AIProviderMarkview.Gates:
swift buildof GenesisKit andswift test --filter ForgeBadgeTestspass; commit subjects andplaceholder-check.shclean.Split out of the unified branch (#507); each commit is a cherry-pick of its unified original.