fix(tools): settle the review threads left open on merged PRs #553-#559 and #507 by genesiscz · Pull Request #561 · genesiscz/GenesisTools

genesiscz · 2026-10-23T12:44:03Z

One commit that settles the review threads still open on the merged PRs #553, #555, #557, #558 and #559, and the 51 outdated #507 threads whose code reached master through them.

Each of the 69 threads was checked against current master:

33 fixed here, each with a regression test that fails on the old code where the behaviour is testable;
34 already fixed by later commits (the reply on each thread cites the code and the test; three got a small wording or test touch-up here);
1 partly fixed (du eviction without developer tools now fails early with the install command; a compiler-free listing path is a separate decision);
1 left on purpose (the mods plugin description, which a pending commit in its owning session rewrites).

Highlights:

azure-devops: local images must sit under --image-root; img src parsed in every valid spelling; read-back keeps inline-tag spaces and Markdown hard breaks and never throws on a bad character reference.
Bash diff hook: command headings masked before the cut; the base-blob head read is bounded at 256 KiB.
typecheck: NUL-delimited git paths; selection reads the program kept after the last pass.
du: top N taken after the provider filter; partners and bigfiles reset the cloud policy; --apply exits 1 on refused evictions; bounded swiftc compile.
readiness: a 500 followed by an unreachable server times out not ready.
GenesisKit / GenesisTools: GenRenderSwap promotions fenced by generation; window-cycle payloads limited to known windows; Hub range links diff from the real first parent; a row-resolved link clears the previous link's failure.
babysit: integrate --dry writes nothing to the vault; SKILL.md landing rules follow the single round policy; a stale brief test updated.

Verification: bun tests of every touched area (556 pass in the changed test files, babysit 158 pass), tsc and typecheck.ts --all clean, biome and lint-rules clean, GenesisKit and GenesisTools Swift suites.

…ges stay under --image-root, readiness drops a stale 500, typecheck reads quoted paths and the last passing program, the diff hook bounds its blob read and masks command headings, du offers only evictable files, and Hub range links diff from the real parent

eve-bot-lovinka · 2026-10-23T12:44:07Z

🐉 eve review — ✅ APPROVE · 2 findings

→ review · run

Queued 12:44:06Z
Reading diff — 41 files
Building repo map
Analyzing (find → verify) — 3 candidates → 2 survivors · reviewed by find codex/gpt-6.1-sol + codex/gpt-6-luna, verify codex/gpt-6-luna
Posting review
Review posted 12:51:50Z (7m 44s)

_{run wrun_01M5MCMKX39A16XMRARY79AFMN}

coderabbitai · 2026-10-23T12:44:25Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Source mode: Auto
Repository: genesiscz/GenesisTools
Branch: fix/2026-10-23-merged-pr-review-followups
File: .coderabbit.yaml
Commit: 7e40b01
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Essentials
Run ID: efc646ab-1178-4810-ab60-1ad30ea7e200

📥 Commits

Reviewing files that changed from the base of the PR and between 27183d0 and 7e40b01.

📒 Files selected for processing: 41

.claude/skills/babysit/SKILL.md
.claude/skills/babysit/scripts/integrate.ts
.claude/skills/babysit/scripts/review-brief.ts
.claude/skills/babysit/scripts/scripts.test.ts
docs/benchmarks-du.md
scripts/ci/typecheck.test.ts
scripts/ci/typecheck.ts
src/agents/README.md
src/agents/lib/hooks/diff/diff.test.ts
src/agents/lib/hooks/diff/run.ts
src/azure-devops/api.ts
src/azure-devops/api.types.ts
src/azure-devops/commands/workitem-update.ts
src/azure-devops/config.ts
src/azure-devops/lib/work-item-update.test.ts
src/azure-devops/lib/work-item-update.ts
src/domains/domains.test.ts
src/domains/lib/suggest/online.ts
src/du/README.md
src/du/lib/cloud-commands.ts
src/du/lib/cloud.test.ts
src/du/lib/engine.ts
src/du/lib/evict.ts
src/du/native/clonesize.c
src/gitlab/lib/review.test.ts
src/hub/lib/agents/index.ts
src/macos/GenesisKit/Sources/GenesisKit/Controls/GenRenderSwap.swift
src/macos/GenesisKit/Sources/GenesisKitDisk/Disk/ToolsDiskProvider.swift
src/macos/GenesisKit/Tests/GenesisKitTests/GenRenderSwapTests.swift
src/macos/GenesisTools/Sources/Host/App/WindowCycle.swift
src/macos/GenesisTools/Sources/Parts/Hub/Hub/HubCommitLink.swift
src/macos/GenesisTools/Sources/Parts/Hub/Hub/HubPRs.swift
src/macos/GenesisTools/Tests/HubLogicTests.swift
src/macos/GenesisTools/Tests/WindowCycleTests.swift
src/macos/GenesisTools/web/diff-viewer/main.ts
src/macos/commands/clones/reclaim.test.ts
src/macos/commands/clones/reclaim.ts
src/ts/lib/collect.ts
src/ts/lib/ts.test.ts
src/utils/DashboardApp/readiness.test.ts
src/utils/DashboardApp/readiness.ts

+-----------------------------------------+
| 💖 Git blame less, Git forgive more 🤝. |
+-----------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

eve-bot-lovinka

🐉 eve review — 🟡 Review comments

7e40b01 · 2 actionable findings · reviewed by find codex/gpt-6.1-sol + codex/gpt-6-luna, verify codex/gpt-6-luna · view run ↗

Severity	Count
🟡 Medium	2

Blast radius

waitForUrlReady (~) → 12 dependent(s) outside this PR: src/utils/DashboardApp/access.ts, src/utils/DashboardApp/lifecycle.ts, src/utils/DashboardApp/preview/openBrowserWhenEnv.ts, +3 more
Api (~) → 8 dependent(s) outside this PR: src/azure-devops/lib/work-item-enrichment.ts, src/azure-devops/inline-images.ts, src/azure-devops/lib/work-item-markdown.test.ts, +2 more
apply (~) → 8 dependent(s) outside this PR: src/macos/GenesisKit/Sources/GenesisKitCharts/HealthBar.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/RingGauge.swift, src/macos/GenesisKit/Sources/GenesisKitBase/Window/SingleInstance.swift, +5 more
show (+) → 5 dependent(s) outside this PR: src/macos/GenesisWidgetPreview/Sources/PreviewApp.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/HealthBar.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/TreemapView.swift, +2 more
loadConfig (~) → 3 dependent(s) outside this PR: src/azure-devops/commands/timelog/configure.ts, src/azure-devops/lib/config-path.test.ts
ensureShim (~) → 2 dependent(s) outside this PR: src/du/lib/bun-scan.ts
parent (+) → 2 dependent(s) outside this PR: src/macos/GenesisKit/Sources/GenesisKitCharts/SquarifiedLayout.swift, src/macos/GenesisKit/Sources/GenesisKitCharts/ChartNode.swift
78 compiler diagnostic(s) on the PR head touch this diff (graph truncated)

ℹ️ Claims vs diff — 8 claims could not be checked from the diff (c1, c2, c3, c4, c5, c6, c7, c8).

eve-bot-lovinka · 2026-10-23T12:51:49Z

        }
    }

+    const requested = opts.cli.apply ? (opts.cli.path ?? []) : [];


🧹 Quality | 🟡 Medium · confidence 98/100

⚠️ Potential issue

Fail explicit apply requests when selection produces no eligible files

The new requested-path failure check is bypassed by the existing chosen.length === 0 return. When the offer contains an eligible file plus a refused file and --apply --path names only the refused file, plan.eligible is nonempty, selectPaths returns [], and runEvict prints 'Nothing selected' and exits successfully without reaching the requested-versus-evicted check. This matters to the exported shared function, which accepts files independently of cli.path (the CLI currently prefilters them). Set exitCode to 1 on that early return when an explicit apply request remains unfulfilled, and cover this mixed-plan case.

🧩 Analysis

Grep evidence: const requested =|chosen.length === 0|requested.some|export async function runEvict

eve-bot-lovinka · 2026-10-23T12:51:49Z

+        rangeLookup = lookup
+        Task {
+            let parent = await Task.detached(priority: .userInitiated) { HubCommitLookup.parent(of: sha, in: root) }.value
+            guard rangeLookup == lookup, self.review === review else { return }


🧹 Quality | 🟡 Medium · confidence 97/100

⚠️ Potential issue

Cancel the pending range lookup when the reader changes scope

The detached parent lookup checks only its UUID and ReviewModel identity. Clicking a commit row calls showCommit, and choosing Whole PR calls showWholePR; both retain the same review and clear pendingCommit but do not invalidate rangeLookup. If either action occurs while git is resolving the parent, this completion subsequently overwrites the reader's chosen scope with the older link's range. Invalidate rangeLookup in these explicit scope-selection paths (and test a delayed lookup followed by a manual selection).

🧩 Analysis

Grep evidence: rangeLookup|func showCommit\(_ commit|func showWholePR|pendingCommit = nil

genesiscz merged commit 7e40b01 into master Oct 23, 2026
5 of 6 checks passed

eve-bot-lovinka Bot approved these changes Oct 23, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix(tools): settle the review threads left open on merged PRs #553-#559 and #507 - #561

fix(tools): settle the review threads left open on merged PRs #553-#559 and #507#561
genesiscz merged 1 commit into
masterfrom
fix/2026-10-23-merged-pr-review-followups

genesiscz commented Oct 23, 2026

Uh oh!

eve-bot-lovinka Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Uh oh!

Uh oh!

eve-bot-lovinka Bot left a comment

Uh oh!

eve-bot-lovinka Bot Oct 23, 2026

Uh oh!

eve-bot-lovinka Bot Oct 23, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

genesiscz commented Oct 23, 2026

Uh oh!

eve-bot-lovinka Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 23, 2026

Uh oh!

Uh oh!

eve-bot-lovinka Bot left a comment

Choose a reason for hiding this comment

🐉 eve review — 🟡 Review comments

Blast radius

Uh oh!

eve-bot-lovinka Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

eve-bot-lovinka Bot Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

eve-bot-lovinka Bot commented Oct 23, 2026 •

edited

Loading