fix: Fix Rust builds by adding a workaround for a GCC bug (#89)#90
Open
larsluthman wants to merge 1 commit into
Open
fix: Fix Rust builds by adding a workaround for a GCC bug (#89)#90larsluthman wants to merge 1 commit into
larsluthman wants to merge 1 commit into
Conversation
On x86_64 with GCC 12.2.0, the following command runs forever, slowly allocating more and more memory: cc -I src -Wall -o parser.o -c src/parser.c Since the cc crate for Rust adds -Wall and -Wextra by default when compiling C code using GCC, this means that cargo build also won't finish. This is probably a bug in GCC, but as a workaround it can be avoided by explicitly disabling -Wall and -Wextra in bindings/rust/build.rs using warnings(false) and extra_warnings(false). Bindings for other languages that also compile the C code using GCC and enable -Wall or -Wextra are probably affected in the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On x86_64 with GCC 12.2.0, the following command runs forever, slowly allocating more and more memory:
cc -I src -Wall -o parser.o -c src/parser.c
Since the cc crate for Rust adds -Wall and -Wextra by default when compiling C code using GCC, this means that cargo build also won't finish.
This is probably a bug in GCC, but as a workaround it can be avoided by explicitly disabling -Wall and -Wextra in bindings/rust/build.rs using warnings(false) and
extra_warnings(false).
Bindings for other languages that also compile the C code using GCC and enable -Wall or -Wextra are probably affected in the same way.