bump go to 1.25 and update go deps#476
Open
Nexucis wants to merge 4 commits into
Open
Conversation
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
Nexucis
force-pushed
the
nexucis/update-go
branch
2 times, most recently
from
2e0106b to
dd453b8
Compare
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
Nexucis
force-pushed
the
nexucis/update-go
branch
4 times, most recently
from
f4fa424 to
23ac756
Compare
Nexucis
commented
Jun 5, 2026
| return func(ctx *fasthttp.RequestCtx) { | ||
| headers := map[string][]string{} | ||
|
|
||
| ctx.Request.Header.VisitAll(func(k, v []byte) { |
Author
There was a problem hiding this comment.
Visitall is a deprecated function, that's why I have replaced it
Nexucis
commented
Jun 5, 2026
| } | ||
|
|
||
| if !(len(a.value) == 0) { | ||
| if len(a.value) > 0 { |
Author
There was a problem hiding this comment.
it's easier and faster to read like that when you do not have to calculate in memory the boolean expression
Nexucis
commented
Jun 5, 2026
| } | ||
|
|
||
| if !(b.value == true) { | ||
| if b.value { |
Author
There was a problem hiding this comment.
value is already a boolean, so comparing to another boolean does not make really sense
Nexucis
commented
Jun 5, 2026
| switch f.DigitSeparator { | ||
| case DigitSeparatorUnderscore: | ||
| separator = "_" | ||
| break |
Author
There was a problem hiding this comment.
break is not necessary in Golang in a switch.
Nexucis
commented
Jun 5, 2026
| httpClient = &clientCopy | ||
| r.config.Client = &clientCopy | ||
| } | ||
| return |
Author
There was a problem hiding this comment.
here there was a possibility for httpClient to be nil. So I have moved the return statement to avoid this situation
Nexucis
force-pushed
the
nexucis/update-go
branch
5 times, most recently
from
7d1b4f8 to
e85b37e
Compare
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
Nexucis
force-pushed
the
nexucis/update-go
branch
from
e85b37e to
f8f128b
Compare
Author
|
I don't get why the build is failing. If you are interested by this PR, do you mind to guide me @gavv ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to update the dependencies of this project. It's been a while it has not been done :)