Conversation
Declare a flat, concern-prefixed policy surface on Assignment (scale_*, zone_*, assign_*, heartbeat_*, retry_*, transport_*) with reserved field-number ranges per concern and three enums (ZoneSpread, ZoneAffinity, Backpressure). The 9 wired knobs feed the supervisor's HPA scaling math, the assignPod handshake, the heartbeat-timeout supervision, and the router's RoundTrip retry loop via resolver methods on *Assignment with cluster-default fallback. Decision sites accept the converge-tick assignment snapshot as a parameter so a tenant override applies uniformly across a single tick. The 15 placeholder knobs (transport_*, zone_*, assign_path, heartbeat_interval, retry_backpressure, retry_status_codes) validate and expose resolver methods but are not read by any decision site; followup plans wire each. Three telemetry keys (scale_target_cpu_millicores, scale_target_memory_mebibytes, scale_target_in_flight_requests) dual-emit alongside the legacy target_* keys; both report the flat-preferred-over-Scale resolved value so dashboards keying on either vocabulary observe identical series.
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
scott-rc
force-pushed
the
sc/assignment-redesign-4
branch
from
May 11, 2026 21:33
afd8290 to
e47b252
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the assignment-redesign plan. Tenants need per-deployment overrides for tunables (HPA tolerance, retry policy, heartbeat timeout, assign timeout, token TTL, scale targets) that currently live as cluster-wide flags. Add a flat, concern-prefixed policy surface on
Assignment(scale_*,zone_*,assign_*,heartbeat_*,retry_*,transport_*) with reserved field-number ranges per concern, three enums (ZoneSpread,ZoneAffinity,Backpressure), and 29 resolver methods on*Assignment. Header validation rejects negative durations, inverted backoff bounds, zero on degenerate fields, and out-of-range scale tolerance.Nine knobs are wired end-to-end through the controller's HPA scaling math, supervisor heartbeat-timeout / scale-to-zero,
assignPodPOST timeout + PASETO token TTL, and the router'sRoundTripretry loop. Decision sites accept the converge-tick*Assignmentsnapshot as a parameter so a tenant override applies uniformly across one tick. The fivescale_*resolvers prefer flat withScalefallback so an existing tenant header continues to work.The remaining 15 placeholder knobs (
transport_*,zone_*,assign_path,heartbeat_interval,retry_backpressure,retry_status_codes) validate and expose resolver methods but are not read by any decision site -- each followup plan wires its own.Three telemetry keys (
scale_target_cpu_millicores,scale_target_memory_mebibytes,scale_target_in_flight_requests) dual-emit alongside the legacytarget_*keys; both report the flat-preferred-over-Scaleresolved value so dashboards keying on either vocabulary observe identical series.Stacked on top of #140 (Phase 3: CLI flags + Web UI routes). Plan:
tmp/assignment-redesign/plan.md.