Conversation
|
I'm updating most dev dependencies to make the linter accept |
| transpileOnly: true, | ||
| }) | ||
| require(tsWorkerPath) | ||
| } catch { |
There was a problem hiding this comment.
I think this catch is going to catch any errors importing the actual target file, like syntax errors or runtime issues. Could we drive the decision to use ts-node or not with an environment variable or some other explicit instruction?
There was a problem hiding this comment.
I think magic flags should be avoided imo, especially given that it only matters in development of this package itself.
.ts files will never appear in the built package, which will make this always throw when distributed, and always load the js file instead.
It's safe in that respect.
I can do it based on the existence of a .ts file instead. Would that be better?
There was a problem hiding this comment.
@airhorns Actually this can be handled really nicely via vite, but I can't do that right now because the test app doesn't use vite. It could be a small project for later if you like.
Introducing multi-threading to off-load React SSR to work threads.
TransformAll hooks are no longer a function, but a path to import a function to useI will leave comments on the diff discussing every important part for easier reviewing
Todos: