[Feat] Add JWT - #12
Merged
Merged
Conversation
Collaborator
Author
|
@g41797 Good, all passed again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the NATS-client, it is just an extra field
jwt, and a matter of not sending the publicKey recalculated because it is already contained in the JWT.For testing, everything is in the CI workflow.
It uses nsc
setup an Oeprator
setup an Account
and use the MEMORY resolver
Then you can create a user dynamically signed by this Account, get the credentials (JWT and seed)
and execute the tests using the JWT and SEED (to sign the nonce sent by the server, who will read the publicKey from the JWT to verify thee JWT, so no need to pass the recomputed publicKey from the seed)
So it is mostly nats-server config.