Repository navigation
feat: enhance logging configuration and redaction capabilities - #113
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical and moderate logging redaction and initialization issues block approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enhances application logging with configurable destinations, formats, and credential/URL redaction.
Changes:
- Adds stdout, file, and combined logging modes with pretty or JSON output.
- Normalizes and documents logging configuration.
- Applies configured logging to command entry points and EVM errors.
- Adds redaction and configuration tests.
File summaries
| File | Summary |
|---|---|
pkg/common/logger/logger.go |
Implements logging configuration, output selection, and redaction. |
pkg/common/logger/logger_test.go |
Tests redaction behavior. |
pkg/common/config/validate_test.go |
Tests logging configuration normalization. |
pkg/common/config/types.go |
Defines logging configuration models. |
pkg/common/config/load.go |
Normalizes logging settings during configuration loading. |
internal/rpc/evm/client.go |
Routes batch errors through the common logger. |
configs/config.example.yaml |
Documents logging options. |
cmd/indexer/main.go |
Initializes logging from configuration. |
cmd/devtools/blockreliability/main.go |
Initializes logging from configuration. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| var ( | ||
| urlInText = regexp.MustCompile(`(?i)(?:https?|redis|rediss|nats)://[^\s"'<>]+`) |
|
|
||
| var ( | ||
| urlInText = regexp.MustCompile(`(?i)(?:https?|redis|rediss|nats)://[^\s"'<>]+`) | ||
| keyValue = regexp.MustCompile(`(?i)\b(password|passwd|secret|token|api[_-]?key|authorization|credential)\b\s*([=:])\s*[^\s,;"']+`) |
Comment on lines
+134
to
+136
| // redactAttr is installed in the slog handler, so it also covers child loggers | ||
| // and direct slog calls after Init. | ||
| func redactAttr(_ []string, attr slog.Attr) slog.Attr { |
Comment on lines
32
to
+36
| once.Do(func() { | ||
| writer := opts.Writer | ||
| if writer == nil { | ||
| writer = os.Stdout | ||
| writer, err := output(opts) | ||
| if err != nil { | ||
| initErr = err | ||
| return |
| key = strings.ToLower(key) | ||
| return strings.Contains(key, "password") || strings.Contains(key, "passwd") || | ||
| strings.Contains(key, "secret") || strings.Contains(key, "token") || | ||
| strings.Contains(key, "api_key") || strings.Contains(key, "api-key") || |
anhthii
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.