Skip to content

feat: Add ignore_archived_cards field in create card transactions, summary, reconciliation summary and reconcile apis - #851

Merged
madangopal122 merged 4 commits into
mainfrom
FYLE-spec-ac-stmt-flow
Jul 27, 2026
Merged

feat: Add ignore_archived_cards field in create card transactions, summary, reconciliation summary and reconcile apis#851
madangopal122 merged 4 commits into
mainfrom
FYLE-spec-ac-stmt-flow

Conversation

@madangopal122

@madangopal122 madangopal122 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Please add PR description here, add screenshots if needed
Screenshot 2026-07-27 at 11 15 36 AM
Screenshot 2026-07-27 at 11 15 52 AM
Screenshot 2026-07-27 at 11 16 02 AM
Screenshot 2026-07-27 at 11 16 20 AM

Clickup

Please add link here

…mmary, reconciliation summary and reconcile apis
Copilot AI review requested due to automatic review settings July 24, 2026 10:24
@github-actions github-actions Bot added the size/M Medium PR label Jul 24, 2026
@github-actions github-actions Bot added size/L Large PR and removed size/M Medium PR labels Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an ignore_archived_cards request field to statement-processing input schemas so API consumers can control whether archived corporate cards are skipped or unarchived during statement processing (create transactions / summary / reconciliation).

Changes:

  • Added ignore_archived_cards to card_transaction_from_statement_in, summary_from_statement_in, reconciliation_summary_from_statement_in, and reconcile_from_statement_in.
  • Reworked statement_archived_cards_in from an allOf composition to an explicit object schema (likely to avoid inheriting new fields).
Comments suppressed due to low confidence (3)

src/components/schemas/statements.yaml:496

  • The new ignore_archived_cards field description mentions "creating card transactions", but this schema is used for the statement summary API. The description should reflect statement summary/reconciliation processing rather than transaction creation.
      description: |
        If true, then the archived cards will be ignored while creating card transactions from the statement.
        If false, then the archived cards will be unarchived and transactions will be created for them.

src/components/schemas/statements.yaml:770

  • The ignore_archived_cards field description refers to "creating card transactions", but this schema is used by the reconciliation summary API. Update the description to be accurate for reconciliation processing.
      description: |
        If true, then the archived cards will be ignored while creating card transactions from the statement.
        If false, then the archived cards will be unarchived and transactions will be created for them.

src/components/schemas/statements.yaml:907

  • The ignore_archived_cards field description refers to "creating card transactions", but this schema is used by the reconcile API (background reconciliation). Update the description to be accurate for reconciliation processing.
      description: |
        If true, then the archived cards will be ignored while creating card transactions from the statement.
        If false, then the archived cards will be unarchived and transactions will be created for them.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/schemas/statements.yaml Outdated
Comment on lines +268 to +270
description: |
If true, then the archived cards will be ignored while creating card transactions from the statement.
If false, then the archived cards will be unarchived and transactions will be created for them.
Comment thread src/components/schemas/statements.yaml
Comment thread src/components/schemas/statements.yaml
Copilot AI review requested due to automatic review settings July 24, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/components/schemas/statements.yaml:1476

  • statement_archived_cards_in no longer defines a top-level required list, so fields like id, statement_mapping, and card_mapping become optional in the schema. Previously these were required (via the earlier allOf composition), so this is a breaking/incorrect contract change.
    card_mapping:
      $ref: '#/card_mapping_in'

Comment thread src/components/schemas/statements.yaml
Copilot AI review requested due to automatic review settings July 27, 2026 05:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (3)

src/components/schemas/statements.yaml:770

  • reconciliation_summary_from_statement_in.ignore_archived_cards is missing an example, unlike the same field in other statement-processing inputs. Adding one keeps the schema docs consistent and easier to understand.
    ignore_archived_cards:
      type: boolean
      nullable: true
      description: |
        Controls how transactions associated with archived cards are handled during statement processing:

src/components/schemas/statements.yaml:907

  • reconcile_from_statement_in.ignore_archived_cards is missing an example, but the same field elsewhere includes one. Adding an explicit example helps make the generated docs consistent.
    ignore_archived_cards:
      type: boolean
      nullable: true
      description: |
        Controls how transactions associated with archived cards are handled during statement processing:

src/components/schemas/statements.yaml:1371

  • statement_archived_cards_in was expanded from an allOf composition into a fully inlined schema that largely duplicates summary_from_statement_in (same id, statement_mapping, ignored_line_item_ids, etc.). This increases the chance of the two inputs drifting over time. Consider reverting to an allOf with $ref: '#/summary_from_statement_in' and only layering additional properties (start_date, end_date) if needed.
statement_archived_cards_in:
  type: object
  properties:
    id:
      allOf:

Comment on lines +492 to +498
ignore_archived_cards:
type: boolean
nullable: true
description: |
Controls how transactions associated with archived cards are handled during statement processing:
If true, transactions associated with archived cards are ignored.
If false, the archived cards are unarchived, and their associated transactions are processed.
Comment thread reference/admin.yaml
Comment on lines 32559 to +32567
statement_archived_cards_in:
allOf:
- $ref: '#/components/schemas/summary_from_statement_in'
- type: object
type: object
properties:
id:
allOf:
- $ref: '#/components/schemas/id_string'
example: stmtadfdsdf
statement_mapping:
type: object
Copilot AI review requested due to automatic review settings July 27, 2026 05:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/components/schemas/statements.yaml:1479

  • statement_archived_cards_in previously required card_mapping (it was required under statement_mapping via the earlier allOf schema). After moving card_mapping to a top-level property, it is no longer listed as required, which changes the request contract and likely makes the request underspecified for mapping statement card numbers to corporate cards. If card_mapping is still required for this endpoint, add it back to the required list.
    card_mapping:
      $ref: '#/card_mapping_in'
  required:
    - id
    - statement_mapping

@madangopal122
madangopal122 merged commit 26b9f5c into main Jul 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large PR

Development

Successfully merging this pull request may close these issues.

3 participants