Repository navigation
fix(ios): keep the web view inside the safe area - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The iOS shell pins its
WKWebViewtoviewinstead of the safe area:The web layer declares
viewport-fit=coverbut never usesenv(safe-area-inset-*)(the stringsafe-area-insetdoes not appear anywhere inpublic/index.html), and the viewport meta also setsmaximum-scale=1.0, user-scalable=no, so the page cannot be zoomed out either.On a Dynamic Island device the top bar renders under the status bar and the message composer under the home indicator. Those strips belong to the system, so the taps never reach the page: the settings button and the send button are unreachable.
Fix
Pin the web view to
safeAreaLayoutGuideand give the hosting view a matching background so the inset strips do not flash white:The insets are resolved by UIKit per device, so nothing is hard-coded: rotation, iPad and devices without a notch keep working (the safe area there is just the status-bar inset).
How to test
Notes
releaseplus this patch (unsigned IPA, installed through SideStore).