Keep coordinates in pixel units - #262
Conversation
…and scale back at import
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 93.86% 93.84% -0.02%
==========================================
Files 59 59
Lines 3358 3398 +40
==========================================
+ Hits 3152 3189 +37
- Misses 206 209 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Design decision: segmentation shape and voxel size should be stored in tracksdata for in-graph segmentations, and thus saved in the geff. External segmentations should have the same metadata in their appropriate file format standards. Aciton item for now: Always show the scale widget pre-filled with whatever metadata is present, and let the user change it during import if needed. Might need a slight hack for our internal save/load to ignore the scale for now. Ideally, later: we should save in world coordiantes (no axis scales), and save the segmentation metadata in tracksdata (blocked by this not existing in tracksdata for voxel size yet). |
|
As per our final decision in #261, this is now keeping the coordinates in pixel units. I did not update the tests_old, so the tests are still expected to fail. |
|
Once we agree to merge this, we should wait for #267, which makes this PR easier |
Scale world coordinates to pixel coordinates when exporting to geff, and scale back at import to align with the geff spec, as a potential solution for #261