Repository navigation
Conversation
The sync auto-start helper treated every refusal from 'sync start' as a failed start. For a local-only team the refusal is 'has no active remote binding', which printed a 'connected, but not syncing' block with a 'sync start' line on every actas. Skip that refusal; a bound-then-disconnected team keeps its note.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
actason a local-only team (never bound to a remote) printed an "AGMSG: connected, but not syncing" block with aremote.sh sync start <team>line. The sync auto-start helper treated the "has no active remote binding" refusal fromsync startas a failed start, and the agent relayed the command to the user.Fix
scripts/lib/sync-autostart.shskips that specific refusal: a never-bound team gets no remote note. A team that was bound and is now disconnected gets a different refusal ("is disconnected") and keeps its note. This covers session-start as well, since both callers use the helper.Cost
No added process spawns: a builtin
caseon the already captured output.Not an automatic stop
Nothing stops, refuses or steps aside; it only removes a misleading message.
Tests
New bats in
tests/test_sync_autostart.bats: fresh local team,actas-claimprintsstatus=okand no remote/sync line; a disconnected team still prints its note. Red on old code (verified), green now. Full file and the four.github/scripts/check-*.shgates pass.