Fix sign extension for fractional power-of-two fixed-point products - #14
Open
nindanaoto wants to merge 2 commits into
Open
nindanaoto wants to merge 2 commits into
nindanaoto wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix fixed-point multiplication by positive fractional powers of two for negative operands.
SGen optimizes multiplication by constants such as
0.5and0.25into shifts. For fractional constants, the generated RTL previously filled the high bits with zeros, effectively performing a logical right shift.Because
FixedPointvalues use signed two's-complement representation, negative operands require an arithmetic right shift. The previous behavior could therefore turn a negative result into a large positive value.Fix
Replicate the input sign bit when shifting right by a fractional power-of-two constant.
Positive operands retain the existing behavior, while negative operands now preserve their sign.
Tests
Add regression coverage for multiplication by:
0.5with positive and negative operands0.25with positive and negative operandsThe first commit adds the regression test and demonstrates the failure on the existing implementation. The second commit applies the fix and makes the test pass.
Tested with:
Result: