Test that a selector outside the input block keeps its order - #1615
Test that a selector outside the input block keeps its order#1615Somberland wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe update comparison now recursively normalizes mapping keys inside blueprint selectors, including nested inputs. Selector key reordering no longer changes fingerprints or settings reports. Selector value changes and unrelated mapping reordering remain detectable. Tests and documentation cover the behavior. ChangesSelector order normalization
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change adds regression coverage so selector configuration reordering inside blueprint inputs does not trigger false updates, while selector-like mappings elsewhere retain their authored order. No merge-blocking risk is evident. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3343771 to
f7b9f4f
Compare
|



Description
A guard test for the scoping decision in #1597: the settings of a selector are settled by walking the input block, not by looking for the key wherever it turns up. This adds the case that pins that down, a mapping named
selectorsitting in the data of an action, where the order is the author's and has to keep counting.It passes on
mainas it stands. This is a regression test, not a fix.Motivation and Context
I came at #1597 from the other end and late: I ran into the reordering on a blueprint of my own on 5.4.0, worked out where it came from, and had opened this PR as a fix before noticing the same fix was already merged and simply not in a release yet. Everything else I had is already covered by the tests that came with it. This one case was not, so that is all this is now.
How has this been tested?
Full suite on
mainwith the test added: 1701 passing. Ruff clean, pylint 10.00/10.Changing
_comparedto settle anyselectorkey wherever it appears, rather than walking the input block, makes it fail. Which is the point of it.Screenshots (if appropriate):
None.
Types of changes
Checklist