Skip to content

pr skill: take the ticket as the argument, lean on the issue, review each change critically #11

Description

@sabind

Learnings from opening #9, #10 and the PR for #2 with /freethinking:pr on 2026-10-13.

Ticket as the argument. The skill's only argument is a base branch, so /freethinking:pr #2 is read as a base override. Take the ticket as the argument (any form: #12, a URL, ENG-1234) and read a GitHub issue up front with gh issue view, so the Why section and the group reasons can lean on the issue text. The author still walks and confirms every change; the issue feeds the why, it does not replace the walkthrough.

Critical review per change, not only "why". The walkthrough asked for a reason and moved on. Give each change a short set of prompts the author answers: what does this change not cover, what would break it, what did you run, what would a reviewer question. For a new eval case that surfaced the untested half of a hypothesis, a missing guard and an unconfirmed run count.

Do not name the ticket twice. The Why bullet says to name the ticket; the repository's own template already asks for Closes #<number>. When the template carries the link, the Why text does not repeat it.

Base branch. Keep the base-branch override reachable, as a second argument or a flag, since the ticket takes the first.

Activity

  1. added
    triageNot yet classified by a maintainer
    on Oct 13, 2026
  2. added theissue type on Oct 13, 2026
  3. added
    qualityThe behaviour of the skills, agents and rules, and the evals and checks that guard it
    and removed
    triageNot yet classified by a maintainer
    on Oct 13, 2026
  4. sabind commented on Oct 13, 2026

    @sabind
    ContributorAuthor

    Triage note: the per-change prompts are applied to every change in the walkthrough, why, how, what it does not cover, what would break it, what was run, so each change ends with its own small summary, and the final description is assembled from those summaries rather than written fresh at the end.

  5. sabind commented on Oct 13, 2026

    @sabind
    ContributorAuthor

    Planning note (2026-10-13): this ships first and alone. A combined PR for #1, #3, #6, #7 and #15 follows it, since #7 quotes this skill's final wording.

  6. self-assigned this
    on Oct 13, 2026
  7. added a commit that references this issue on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: highDo firstqualityThe behaviour of the skills, agents and rules, and the evals and checks that guard it

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions