fix(writer): fix DOCX export and rewrite exporter for correct, professional formatting - #515
Open
DikshaJadhav3110 wants to merge 8 commits into
Open
fix(writer): fix DOCX export and rewrite exporter for correct, professional formatting#515DikshaJadhav3110 wants to merge 8 commits into
DikshaJadhav3110 wants to merge 8 commits into
Conversation
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (6): Last reviewed commit: "test(writer): add unit tests for DOCX ex..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…cursive conversion
Exports the small, pure conversion helpers in docxexporter.js (color/font/ size mapping, image sizing, list numbering, column-width distribution, etc.) and adds focused unit tests for each, following the existing xlsx-io.js convention: plain input/output assertions with tiny duck-typed DOM stubs, no real DOCX generation or parsing. Also adds a .d.ts shim so importing from the untyped .js file doesn't warn in editors. Coverage was verified with mutation testing (Stryker, run ad hoc, not added as a dependency), which surfaced and fixed several real gaps: whitespace-padded font-family lookups silently missing the font map, zero/negative image dimensions not being rejected, a malformed colwidth segment corrupting column-width distribution, and randomId's fallback chain never being exercised for a stripped-down crypto object. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the broken Export → DOCX functionality and significantly improves DOCX export quality.
editor.value.getHTML()andprops.file, resolving the silent failure where clicking Export → DOCX did nothing.FDialogs.vue: Restored support for themessageprop, fixing a latent issue affecting dialogs across the application.Closes #514
Screen.Recording.2026-08-07.at.1.41.47.PM.mov