Skip to content
This repository was archived by the owner on Jul 3, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions drive/api/product.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,15 +363,19 @@ def get_translations():
return get_all_translations(language)


def is_drive_site_admin():
return frappe.has_permission("Drive Disk Settings", "write")
Comment thread
safwansamsudeen marked this conversation as resolved.


@frappe.whitelist()
def is_site_admin():
return {"is_admin": "Drive Admin" in frappe.get_roles()}
return {"is_admin": is_drive_site_admin()}


@frappe.whitelist(allow_guest=True)
def disk_settings(**kwargs):
settings = frappe.get_single("Drive Disk Settings")
if not is_site_admin()["is_admin"]:
if not is_drive_site_admin():
# Return only safe values
return {"preview_size": settings.preview_size, "enabled": settings.enabled}

Expand Down
19 changes: 11 additions & 8 deletions drive/drive/doctype/drive_disk_settings/drive_disk_settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"engine": "InnoDB",
"field_order": [
"general_section",
"jwt_key",
"preview_size",
"use_drive_for_files",
"disk_section",
Expand Down Expand Up @@ -85,12 +84,6 @@
"fieldtype": "Data",
"label": "Thumbnail prefix"
},
{
"fieldname": "jwt_key",
"fieldtype": "Data",
"label": "JWT Key",
"options": "Dangerous - if leaked, all files can be accessed."
},
{
"default": "100",
"description": "Used to configure maximum file sizes of in-browser previews (in megabytes).",
Expand Down Expand Up @@ -129,12 +122,22 @@
"index_web_pages_for_search": 1,
"issingle": 1,
"links": [],
"modified": "2026-03-06 14:48:40.048946",
"modified": "2026-06-16 18:24:47.598513",
"modified_by": "Administrator",
"module": "Drive",
"name": "Drive Disk Settings",
"owner": "Administrator",
"permissions": [
{
"create": 1,
"delete": 1,
"email": 1,
"print": 1,
"read": 1,
"role": "Drive Admin",
"share": 1,
"write": 1
},
{
"create": 1,
"delete": 1,
Expand Down
Loading