feat: redone Framework integration

[safwansamsudeen]

Drive’s entity model moves from a parallel Drive File doctype onto Frappe’s framework File, extended with Drive custom fields and a subclass override. One row type powers the SPA, desk attachments, Writer documents, presentations, and S3/disk storage.

---

Why

• One source of truth — listings, permissions, trash, and desk attachments all read the same File rows.
• Framework integration — stock upload/attach flows can route through Drive without a shadow doctype.
• Clearer semantics — explicit kind and content_doctype replace overlapping modifiable / is_attachment flags.

This is a breaking migration. Sites with existing Drive data must run bench migrate before using the new frontend.

---

Architecture

flowchart LR
  subgraph before [Before]
    DF[Drive File]
    DD[Drive Document]
    DF --> DD
  end

  subgraph after [After]
    FF[framework File]
    WD[Writer Document]
    PR[Presentation]
    FF -->|content_doctype| WD
    FF -->|content_doctype| PR
    FF -->|content_doctype File| LIB[library File ref]
  end

  before -->|integrate_with_framework| after

Loading

Framework File custom fields

Field	Purpose
team	Drive team scope (null = site / framework file)
status	Active / Trashed / Removed (tombstone before hard delete)
file_modified	User-visible “modified” without touching framework modified
mime_type	Drive MIME (framework field is unreliable for our blobs)
content_doctype / content_docname	Backing record — Writer Document, Presentation, or another File (attachment ref)

Listing kind (replaces modifiable / is_attachment)

Every Drive listing row carries exactly one kind:

kind	Meaning	Rename / move / share
native	Drive-managed team file	✅
readonly	Shown in Drive but not managed here	❌
virtual	Fabricated Doctype→Doc grouping node (not a DB row)	❌

readonly sub-cases use existing fields — no extra kind values:

• !team → site / framework file → “Open in Desk”
• content_doctype === "File" → attachment ref → “Go to original”

Frontend uses isManaged / isReadonly / isVirtual for gates, and isSiteFile / isAttachmentRef for the two readonly actions (GenericPage, Navbar, InfoPopup).

This delineation will be removed in a follow up PR, and all files will be editable through Drive.

drive.overrides.file.File

Team-scoped files use a File subclass for Drive behavior:

• Lifecycle — after_insert (activity log), after_delete (cascade folders, related rows, backing content doc), on_rollback (upload cleanup)
• Operations — move, rename, share, unshare, permanent_delete, toggle_favourite
• Guards — is_private enforced in validate; desk rename blocked unless via Drive UI (flags.drive_disk_rename)
• Disk — skip path moves when _not_in_disk() (Link, empty file_url, or any content_doctype)

has_permission on "File" delegates to Drive ACLs; site files fall through to framework permissions.

---

Migration

Patch: drive.patches.integrate_with_framework (pre_model_sync)

1. Reads legacy tabDrive File (if it still exists)
2. Inserts matching framework File rows (same IDs via _name)
3. Maps content_doctype / content_docname for Writer docs & presentations
4. Sets frappe.flags.mute_drive_activity_log so bulk insert doesn’t spam activity logs

After migrate, legacy Drive File tables can be dropped when the doctype is removed from code.

Upgrade path: deploy → bench migrate → verify listings → remove Drive File doctype in a follow-up.

Fresh install: patch no-ops (no legacy table); custom fields sync via fixtures.

---

Desk integration

• Library tab → Drive picker (drive/public/js/ff_integration.bundle.js, FileUploader.vue)
  • Site / Home / Teams tabs, folder navigation, infinite scroll, search
  • Attach existing file or upload into a chosen Drive folder
• after_upload_file — when “use Drive for files” is on, framework uploads land in the user’s personal Drive home (with safe fallback when no personal team exists)

---

Removed / deprecated doctypes

Removed	Replaced by
Drive File	framework File (+ override) — doctype folder still present until B1 cleanup lands
Drive Document	Writer Document (Writer app)
Drive Comment, Drive Doc Version, Drive Document Version	Writer / activity model
Drive Disk Settings	consolidated elsewhere
Drive Tag / Drive Entity Tag / tags API	dropped in this branch
Drive Desktop Client	dropped

---

Notable fixes

• S3 — storage_key() centralizes key derivation; s3.fetch serves through get_file_content with uniform 404 (no guest enumeration)
• Trash — clear_deleted_files date math; status Select instead of magic ints
• Permissions — has_permission on "File"; stricter move/unshare checks
• List API — bounded share-count queries; share_count priority collision fixed
• Upload — embed path typo (file_name); sync_from_disk file_type fix
• Activity — move events logged; create events on insert
• Presentation sync — hooks use File + content_docname, not Drive File

---

Frontend & toolchain (bundled)

This PR also ships formatting/tooling churn from the long-lived branch.

• pnpm → yarn, Vite 4 → 8, frappe-ui as npm dependency
• Prettier pass across frontend
• kind-based UI gates (native / readonly / virtual); field-based readonly actions
• Writer routes redirect to /writer/w/ (legacy Document.vue removed)

---

Upgrade commands

# backup first
bench --site <site> backup

# deploy ff-file, then:
bench --site <site> migrate
bench build --app drive

If migration reports failures, check integrate_with_framework output for file names that failed to insert.

[safwansamsudeen]

@federicocalvo @nilpatel42 please let me know if you're interested in alpha testing 😄 (DM @realsafwan).

[federicocalvo]

This should be a real game-changer in terms of encouraging the use of the drive