fix: use axis number formatter for values over points - #434
Open
kaulith wants to merge 1 commit into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Y-axis labels honour
axisOptions.numberFormatter, but the values drawn over bars do not; they callshortenLargeNumberdirectly, which has a hardcodedK/M/B/Tsuffix table. On any chart that passes a formatter, the two disagree.Frappe hits this on every dashboard chart with "Show Values Over Chart" enabled on an Indian-locale site.
frappe.utils.make_chartpasses a formatter that returns the Indian number system, so the axis reads6 Crwhile the bar labels on the same chart read56M. Same numbers, two unit systems, one chart.Routing the value labels through the configured formatter fixes it. The stacked branch is folded into the same path; it was passing
cumulativeYsthrough unformatted, so stacked totals printed in full while the axis was shortened. Charts that pass no formatter keep the existingshortenLargeNumberoutput, so nothing changes for anyone not setting one.