[Heatmap] Localize Tooltip Date formatting - #162
Open
kimili wants to merge 14 commits into
Open
Conversation
`datasets` have `name`, not `title`
Update README.md
Contributor
|
@kimili Could you send this to |
kimili
force-pushed
the
feature/localize-date-heatmap-tooltip
branch
2 times, most recently
from
April 23, 2018 13:37
80390c7 to
750be23
Compare
# Conflicts: # dist/frappe-charts.min.cjs.js # dist/frappe-charts.min.cjs.js.map # dist/frappe-charts.min.esm.js # dist/frappe-charts.min.esm.js.map # dist/frappe-charts.min.iife.js # dist/frappe-charts.min.iife.js.map # docs/assets/js/frappe-charts.min.js # docs/assets/js/frappe-charts.min.js.map # docs/assets/js/index.min.js # docs/assets/js/index.min.js.map
Contributor
Author
|
@pratu16x7 - Done. I was having some trouble with conflicts in the compiled files, but I ended up resolving them with the changes that are currently in the |
|
Is there any new progress here? I'm also interested in this adaptation because I don't like American formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation About What Code Achieves:
The current date formatting in the heat map tooltips is hard coded in a way that makes it odd for some locales. This patch makes the date formatting in the heat map tooltips nicer. Specifically:
Dateobject'stoLocaleDateString()method.toLocaleDateString()optionsparameter.Screenshots/GIFs:
The default formatting in the
en-USlocaleThe default formatting in the
en-GBlocale