Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review: install Arcanea editorial contract Reviewed the diff for #117. This is a docs/config change (no app code), so most standard categories (perf, test coverage) don't really apply — focused on correctness of the contract config and CI wiring. Security — good. The reusable workflow ( Potential bug — content_roots don't match this repo's layout. Minor — five-way content duplication. The same editorial-contract block is duplicated verbatim across Unverified. I wasn't able to reach the GitHub API for the external Nitpick. The workflow triggers on Everything else (the managed-block pattern, the pinned SHA references being consistent across all seven files, the new SKILL.md and .cursor/rules/editorial.mdc) looks straightforward and correctly wired. |
Every pull_request-triggered workflow here ran its full install/build/test matrix on every push to every draft. Estate rule (starlight CLAUDE.md "Git-Ops & CI Cost Discipline"): heavy jobs skip drafts and fire once on ready_for_review; cheap linters keep running so drift and leaked secrets are caught on the first push. Per workflow: - claude-code-review, deploy-apps (test-and-build), mvp-deploy (security, quality, build, database), packages-ci (test matrix), quality-gate (quality, build), test (cli-tests, typecheck, security): draft-gated. - lore-canon, magic-validate, web-excellence, secret-literal-guard, packages-ci security grep, quality-gate release-integrity: deliberately NOT gated - no install, seconds to run. - claude.yml is comment/issue-triggered, not pull_request; bounded only. - Every pull_request trigger now lists ready_for_review. Without it the gate skips the jobs and marking the PR ready never re-fires them, so the required checks stay unreported and the PR cannot merge. - concurrency + cancel-in-progress on the five workflows that lacked it; timeout-minutes on every reachable job. mvp-deploy's Vercel jobs are untouched: #118 already hard-stops them. Folded into #117 rather than opened separately: frankxai/arcanea is at 14 open PRs against a budget of 10. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Installs the Arcanea editorial contract pinned to
50ae34c7ac06e6c083f277ca96c3bde8f0a39b43.Canonical source: frankxai/starlight-design-intelligence#14
Folded in: estate draft gate on every pull_request workflow (commit 2d8d5a2)
frankxai/arcanea is at 14 open PRs against a budget of 10, so this rides here instead of a 15th PR.
ready_for_review): claude-code-review; deploy-appstest-and-build; mvp-deploysecurity/quality/build/database; packages-citest; quality-gatequality/build; testcli-tests/typecheck/security.ready_for_reviewadded to everypull_requesttrigger so marking ready re-fires the gated checks.concurrency+cancel-in-progressandtimeout-minuteson every reachable job.mainto pick up ci: never vercel --prod from public frankxai/arcanea #118 and Security: remove hard-coded Gemini credentials and add CI guard #120.This PR is itself a draft, so its own checks now demonstrate the gate: heavy jobs should show as skipped, cheap linters as run.