Repository navigation
Use the configured size type for sequence arguments - #276
Open
zakariyaghazzol wants to merge 2 commits into
Open
zakariyaghazzol wants to merge 2 commits into
zakariyaghazzol wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
Adopt the dictionary's unsigned SeqArgs size field and validate its capacity. Restore the layout and constructor defaults when switching cached dictionaries, and reset U64 when SeqArgs is absent.
Add 22 regressions for byte layouts, defaults, cache switching and sequence-call boundaries.
Testing: 1,684 passed with one existing XPASS; related suite 112 passed. Both real C++ harnesses rebuilt/probed as 32-bit and 64-bit executables with matching dictionaries; empty, constant, variable and full-capacity child calls pass with independently checked command bytes. The original compiler rejects the same U32 dictionaries. Black and diff checks pass.
No runtime, submodule, dependency or workflow changes included. The existing supplied Wasm harness compatibility patch was used locally.