Repository navigation
Update spelling action to fix fork PR checks - #270
Conversation
|
@zakariyaghazzol thanks for this PR. Can you please retarget/rebase on devel? |
d8c5ac4 to
d15311b
Compare
You're right about that; thanks for the correction. I’m rebasing this onto devel and checking the fork-side test triggers. I’ll follow up with the results. |
d15311b to
1bd8d39
Compare
|
Rebased onto Fork-side tests now run automatically on pushes. All 36 jobs across my nine open PRs passed on Python 3.10–3.13: results. The additional CI automation stays on my fork, outside these PRs. |
|
@zimri-leisher I noticed #270 was merged into devel, but main still uses check-spelling v0.0.24. The latest spelling runs across my open PRs all used that version and failed at the same permissions check. Would it make sense to apply just the workflow fix from #270 to main as well, or is there a reason to keep it on devel for now? |
|
I merge devel in to main when I release a new Fpy version. I think you just have to pull in devel |
ahh gotcha |
|
@zimri-leisher I pulled in devel for #272 as you suggested. Fork spelling and unit tests on Python 3.10–3.13 now pass. Even after that update, the separate upstream spelling run still loads v0.0.24 from main through pull_request_target and fails the same permissions check. |
Change Description
Pin check-spelling v0.0.26 by commit SHA and remove the unsupported
tags-ignorefilter frompull_request_target. Permissions, dictionaries, and other action inputs are unchanged.Rationale
v0.0.24 stops fork PRs at its permission check after a GitHub API response change. v0.0.26 includes the upstream fix. This keeps the CI update separate from the test changes in #267.
Testing/Review Recommendations
422response; v0.0.26 proceeds past that check. These are not full action runs.git diff --checkpasses.A real upstream fork-PR run is still needed. If allowed-action restrictions are enabled, review the updated
check-spelling/checkout-mergedependency noted in the release.Future Work
The upstream default-branch workflow needs this update before it can affect
pull_request_targetruns. This PR may still encounter the old check until the update is adopted there.