Skip to content

Update spelling action to fix fork PR checks - #270

Merged
zimri-leisher merged 1 commit into
fprime-community:develfrom
zakariyaghazzol:fpy-spelling-check
Oct 22, 2026
Merged

zimri-leisher merged 1 commit into
fprime-community:develfrom
zakariyaghazzol:fpy-spelling-check

Conversation

@zakariyaghazzol

Copy link
Copy Markdown
Related Issue(s) CI follow-up to #267
Has Unit Tests (y/n) N/A — workflow-only change
Documentation Included (y/n) N/A

Change Description

Pin check-spelling v0.0.26 by commit SHA and remove the unsupported tags-ignore filter from pull_request_target. Permissions, dictionaries, and other action inputs are unchanged.

Rationale

v0.0.24 stops fork PRs at its permission check after a GitHub API response change. v0.0.26 includes the upstream fix. This keeps the CI update separate from the test changes in #267.

Testing/Review Recommendations

  • actionlint v1.7.12 passes; the original workflow reports the unsupported tag filter.
  • Eight local workflow-contract and isolated dispatcher fixture checks pass. The old dispatcher reproduces exit 5 with a simulated 422 response; v0.0.26 proceeds past that check. These are not full action runs.
  • git diff --check passes.

A real upstream fork-PR run is still needed. If allowed-action restrictions are enabled, review the updated check-spelling/checkout-merge dependency noted in the release.

Future Work

The upstream default-branch workflow needs this update before it can affect pull_request_target runs. This PR may still encounter the old check until the update is adopted there.

@zimri-leisher
zimri-leisher changed the base branch from main to devel October 21, 2026 12:32
@zimri-leisher
zimri-leisher changed the base branch from devel to main October 21, 2026 12:33
@zimri-leisher

zimri-leisher commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

@zakariyaghazzol thanks for this PR. Can you please retarget/rebase on devel?
Also, I'm wondering why the UTs aren't automatically running on your fork. Worth taking a look into. I'm gonna wait to merge other PRs of yours until we figure this out

@zakariyaghazzol
zakariyaghazzol changed the base branch from main to devel October 21, 2026 21:34
@zakariyaghazzol

Copy link
Copy Markdown
Author

@zakariyaghazzol thanks for this PR. Can you please retarget/rebase on devel? Also, I'm wondering why the UTs aren't automatically running on your fork. Worth taking a look into. I'm gonna wait to merge other PRs of yours until we figure this out

You're right about that; thanks for the correction. I’m rebasing this onto devel and checking the fork-side test triggers. I’ll follow up with the results.

@zakariyaghazzol

Copy link
Copy Markdown
Author

Rebased onto devel and updated the target. The devel-only push filter was why UTs weren’t starting on my feature branches.

Fork-side tests now run automatically on pushes. All 36 jobs across my nine open PRs passed on Python 3.10–3.13: results.

The additional CI automation stays on my fork, outside these PRs.

@zimri-leisher
zimri-leisher merged commit 42571c1 into fprime-community:devel Oct 22, 2026
6 of 7 checks passed
@zakariyaghazzol

zakariyaghazzol commented Oct 26, 2026 •

Copy link
Copy Markdown
Author

@zimri-leisher I noticed #270 was merged into devel, but main still uses check-spelling v0.0.24. The latest spelling runs across my open PRs all used that version and failed at the same permissions check. Would it make sense to apply just the workflow fix from #270 to main as well, or is there a reason to keep it on devel for now?

@zimri-leisher

Copy link
Copy Markdown
Collaborator

I merge devel in to main when I release a new Fpy version. I think you just have to pull in devel

@zakariyaghazzol

Copy link
Copy Markdown
Author

I merge devel in to main when I release a new Fpy version. I think you just have to pull in devel

ahh gotcha

@zakariyaghazzol

Copy link
Copy Markdown
Author

@zimri-leisher I pulled in devel for #272 as you suggested. Fork spelling and unit tests on Python 3.10–3.13 now pass. Even after that update, the separate upstream spelling run still loads v0.0.24 from main through pull_request_target and fails the same permissions check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants