CI: exclude gcc@11 on macos-14 (arm64) - #1194
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
=======================================
Coverage 68.84% 68.84%
=======================================
Files 408 408
Lines 13726 13726
Branches 1552 1552
=======================================
Hits 9450 9450
Misses 4276 4276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jvdp1
left a comment
There was a problem hiding this comment.
LGTM.
Should it be added to the list of not supported compilers/OS in the Readme?
|
It used to work and it stopped working recently, which makes me think it is probably due to upgrades on github runners or the homebrew packaging and not necessarily because there is a fundamental issue. So I wouldn't add it to the list in such a formal manner because in principle it "ought to work" |
Thank you for the explanation. In that case, I agree to not add it in the README. This PR can be merged IMHO. |
|
https://github.com/fortran-lang/stdlib#supported-compilers Well, it's true that now that list doesn't hold in terms of tested combinations... I see different options: Option 1: Try to test using https://github.com/gha3mi/setup-fortran-conda or https://github.com/minhqdao/setup-fortran instead of the current setup-fortran action and see if it works Option 2: have a section with list of supported combinations that used to work but that are not tested anymore due to runners/actions changes which are out of our hands We can merge this PR and go for either of those in another PR? |
There is already a table like this in the README. It could be added in this table. |
* Initial plan * Fix CI: exclude gcc@11 on macos-14 (arm64) due to post-install failure --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
brew install gcc@11fails on macOS 14 (arm64/Apple Silicon) because the post-install step exits with code 1, causing the entiresetup-fortranstep to fail and all subsequent cmake steps to be skipped.Changes
.github/workflows/CI.yml: Add{os: macos-14, toolchain: {compiler: gcc, version: 11}}to the matrixexcludelist — mirrors the existing exclusion ofgcc@10onmacos-14for the same reason.