SPRNGCORE-18: Handle Jackson changes and address SonarQube reported concerns.#122
Merged
Merged
Conversation
…oncerns. Explicitly define Jackson 2 behavior: - The `MapperFeature.DEFAULT_VIEW_INCLUSION` is `true` by default in **Jackson 2** but not in **Jackson 3**. Remove unecessary code snippets: - The `@RequestHeader` has unnecessary `value = ""` annotations. - The `ResponseEntity<>` does not need arguments specified in the `return` lines. Replace overlooked deprecated `@Nullable` use: - Switch to `org.jspecify.annotations.Nullable`. Avoid using `@Autowired` on variable declarations and instead provide an initializer function.
|
rmathew1011
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further resolves SPRNGCORE-18, addressing things overlooked in previous upgrade effortss.
Explicitly define Jackson 2 behavior:
MapperFeature.DEFAULT_VIEW_INCLUSIONistrueby default in Jackson 2 but not in Jackson 3.Remove unecessary code snippets:
@RequestHeaderhas unnecessaryvalue = ""annotations.ResponseEntity<>does not need arguments specified in thereturnlines.Replace overlooked deprecated
@Nullableuse:org.jspecify.annotations.Nullable.Avoid using
@Autowiredon variable declarations and instead provide an initializer function.