Repository navigation
Conversation
4 tasks done
The verdict was printed and nothing else, so no later pass could read it and the pipeline stopped exactly where specialisation would begin. Each queue's root, its cir.global or cir.alloca, now carries its verdict as wtc.queue_kind, and so does every push and pop. Since one op can reach several queues -- a helper called with each of two -- an op carries the join of its queues' verdicts, the weakest: a verdict is three facts (several producers, several consumers, unknown) and the join ors them. An op with an access that reached no queue the analysis could name is UNKNOWN. The stdout report is unchanged, so every existing test still holds. The attribute and the stamping are carried over from 253a2bc (feat/select-queue-impl), extended to roots and to the join. Verified: 24 of 24 pass, no warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ZweZeya
force-pushed
the
feat/queue-kind-in-ir
branch
from
October 18, 2026 05:20
b98246d to
9d20b82
Compare
ZweZeya
force-pushed
the
fix/analysis-soundness
branch
from
October 18, 2026 05:20
30eca14 to
25d430f
Compare
Collaborator
|
Closing as superseded by #10. The verdict is written into the IR there as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3 (
fix/analysis-soundness).What this changes
The verdict was printed and nothing else, so no later pass could read it. Each queue's root (
cir.globalorcir.alloca) now carrieswtc.queue_kind, and so does every push and pop. One op can reach several queues, so an op carries the join of their verdicts, the weakest (several producers / several consumers / unknown, or-ed). The stdout report is unchanged. The attribute and the stamping come from 253a2bc, extended to roots and to the join.How it was checked
25 of 25 pass, no warnings:
queue-kind-attribute.mlir(ported from 253a2bc) andqueue-kind-join.mlir(one push reaching an SPSC and an MPSC queue is MPSC; each global keeps its own).Checklist
🤖 Generated with Claude Code