itrace.py: fix MIPS call/return mnemonics and delay-slot EA print - #24
Open
Mr-Pine wants to merge 2 commits into
Open
itrace.py: fix MIPS call/return mnemonics and delay-slot EA print#24Mr-Pine wants to merge 2 commits into
Mr-Pine wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dot-asm
reviewed
Aug 8, 2026
|
|
||
| def isFunctionReturn(self, b): | ||
| return b.group(1) == "jr" and b.group(2) == "ra" | ||
| return b.group(1) == "jr" and b.group(2).lstrip("$") == "ra" |
Contributor
There was a problem hiding this comment.
I don't follow. itrace.py collects disassembler output from gdb and [MIPS] disassembler doesn't decorate registers with dollar signs. What is your gdb version?
Author
There was a problem hiding this comment.
I just quickly checked against my gdb which had pwndbg installed and displayed the registers with $. Should have checked properly, sorry ._.
dot-asm
approved these changes
Aug 10, 2026
dot-asm
left a comment
dot-asm
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks!
On a related note. MIPS6 instroduced no-delay-slot branches and removed branch likely-s. As it stands, the scripts doesn't handle either. Would you consider fixing it? If you have energy of course. As separate PR. Do tag me, if you do ;-)
Author
|
I'll keep it in mind if I have the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the use of the
labelfunction in the MIPS extractor and fixes mnemonics for calls (jal) and the return address register (prefixed with $ in mips)