Unify and harden HTTP server request limits - #1361
Merged
Merged
Conversation
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
matheuscscp
approved these changes
Aug 6, 2026
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Member
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/v1.9.x
git worktree add -d .worktree/backport-1361-to-release/v1.9.x origin/release/v1.9.x
cd .worktree/backport-1361-to-release/v1.9.x
git switch --create backport-1361-to-release/v1.9.x
git cherry-pick -x 8bb6b148850ce58d2de938bfa81d35acff56e286 6662c7810314bc5d677785c46caaab77e25d2fb5 c80e3914b5440d6568aeff91649d8deb30294c26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies defense-in-depth hardening to the two HTTP servers exposed by the controller:
ReadTimeout(30s),ReadHeaderTimeout(10s) andMaxHeaderBytes(256 KiB) on both servers.--rate-limit-intervaland purging them after 2x interval.sethvargo/go-limiterfrom v1.1.0 to v1.2.0, which reduces lock contention in the store.