Fix HasBeenTested for all corner cases - #1547
Merged
matheuscscp merged 1 commit intoJul 23, 2026
Merged
Conversation
Member
|
If I understand correctly, this fix implies that a non-empty list of zero TestHooks still means the release was not tested, but it's also semantically different from an empty list of TestHooks? Why is that? |
matheuscscp
force-pushed
the
1546-controller-confused-when-test-hook-fails-with-403
branch
from
July 23, 2026 11:01
19003f7 to
f7da5ae
Compare
matheuscscp
changed the title
HasBeenTested to return true only when all filtered test hooks were tested
matheuscscp
added
bug
tested Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com> Signed-off-by: d.small@sap.com <d.small@sap.com>
matheuscscp
force-pushed
the
1546-controller-confused-when-test-hook-fails-with-403
branch
from
July 23, 2026 11:18
f7da5ae to
d8452e2
Compare
matheuscscp
changed the title
HasBeenTested to return true only when all filtered test hooks were testedHasBeenTested for all corner cases
Member
|
Successfully created backport PR for |
Contributor
Author
|
Hey @matheuscscp Thanks for the review and the question. I was wanting to just address the problem my team was having without having to worry about any subtleties of how HasBeenTested is used. Also thanks @stefanprodan :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #1546
Updated test status handling so a release only counts as tested when all selected test hooks have reached a terminal phase. Empty selected hook sets still count as tested for charts with no matching tests. Filtered-out hooks are no longer recorded in the snapshot, avoiding false incomplete results from intentionally skipped tests.