fix(goreleaser): make Homebrew formula pass brew audit - #5973
Open
trademomentumllc wants to merge 1 commit into
Open
fix(goreleaser): make Homebrew formula pass brew audit#5973trademomentumllc wants to merge 1 commit into
trademomentumllc wants to merge 1 commit into
Conversation
Update the generated Homebrew formula to avoid two common brew audit --strict failures: - Description no longer starts with the formula name. - Test system call uses separate arguments instead of a shell string. This ensures future releases of flux publish a compliant formula to fluxcd/homebrew-tap.
Member
|
@trademomentumllc please signoff your commit, see: https://github.com/fluxcd/flux2/pull/5973/checks?check_run_id=85051958719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two common
brew audit --strictfailures in the generated Homebrew formula:systemcall uses separate arguments instead of a shell string.This ensures future releases of Flux publish a compliant formula to fluxcd/homebrew-tap.
Related to fluxcd/homebrew-tap#17.