docs(notebooks): port compute qmd notebook fixes - #528
Merged
Conversation
Contributor
|
Spell check passed successfully for 2 notebook(s). |
marcorudolphflex
marked this pull request as ready for review
June 24, 2026 08:25
marcorudolphflex
force-pushed
the
marco/port-compute-qmd-edits-pre212
branch
from
June 24, 2026 09:29
4607173 to
763b79c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Autograd12LightExtractor.qmdhistory filename fix back into the source notebook:misc/qe_light_coupler_autograd.pkl->misc/qe_light_coupler.pkl.ChargeSolver.qmdPalankovski & Quay carrier lifetime update back into the source notebook.Why
These edits were made directly in compute qmd files after the Quarto migration, but they were not present in
tidy3d-notebooksondeveloporpre/2.12. Keeping them only in generated qmd files makes future notebook-to-qmd syncs regress those docs.The related compute changes were:
flexcompute/compute#5392by Dario:Autograd12LightExtractor.qmdhistory filename fix.flexcompute/compute#5322by Marc:ChargeSolver.qmdPalankovski & Quay carrier lifetime docs/code update.The
Autograd23FabricationAwareInvdes.qmdchange from compute was whitespace-only generated qmd cleanup, so there is no source-notebook change to port.Rerun result on ChargeSolver
Validation
python3 -m json.tool Autograd12LightExtractor.ipynb ChargeSolver.ipynb custom_dictionary.jsonuvx ruff==0.14.1 format --check --diff Autograd12LightExtractor.ipynb ChargeSolver.ipynbuv run --no-project python scripts/validate_notebook_metadata.py Autograd12LightExtractor.ipynb ChargeSolver.ipynbuv run --no-project ./spellcheck.py Autograd12LightExtractor.ipynb ChargeSolver.ipynbpython3 misc/check_misc_references.pyuv run --no-project python scripts/sync_metadata_tags.py --checkgit diff --check origin/pre/2.12..HEADNote: spellcheck prints existing invalid-metadata messages from unrelated reference notebooks while building its dictionary, but exits successfully for the changed notebook set.
Note
Low Risk
Documentation-only path string in a notebook; no runtime, auth, or API behavior changes.
Overview
Ports a compute-side Quarto doc fix back into the source notebook by renaming the optimization history file from
misc/qe_light_coupler_autograd.pkltomisc/qe_light_coupler.pkl.save_history/load_historystill use the samehistory_fnamevariable—only the path string changes so future notebook→qmd syncs match the published docs and bundledmiscasset name.Reviewed by Cursor Bugbot for commit 763b79c. Bugbot is set up for automated code reviews on this repo. Configure here.