Repository navigation
automation: accept timezone on rule update - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做了什么
更新自动化规则的 SDK 请求补上
timezone。不传这个字段时，原来的时区保持不动，包括老数据里的空串。显式传空字符串会把时区写成 UTC，不会改回账号默认时区。OpenAPI 里这个字段本来就有，这次只让手写的
AutomationRuleUpdateRequest能把它发出去。怎么验证
go test -count=1 -run TestAutomationRuleUpdateRequestTimezone .