Repository navigation
fix(incident): fetch get by id through /incident/list-by-ids - #215
Merged
Merged
Conversation
`incident get <id>...` sent only incident_ids to /incident/list. That endpoint requires a start_time/end_time window, so every call failed with "StartTime is a required field, EndTime is a required field" (HTTP 400). Fetch through /incident/list-by-ids, which takes ids alone and returns the same row shape. Short-id resolution still goes through /incident/list with its 30-day lookback. Tests now assert the request path, which the previous stub did not check.
fix(incident): fetch `get` by id through /incident/list-by-ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #214 to main for the v1.5.13 release.
incident get <id>...sent onlyincident_idstoPOST /incident/list, which requiresstart_time/end_time, so every call returned HTTP 400. It now fetches throughPOST /incident/list-by-ids; short-id resolution still uses/incident/listwith its 30-day lookback. Verified against a live dev backend (single, short and multi id; json and table). Details in #214.🤖 Generated with Claude Code