chore(e2e): upgrade Playwright and run e2e on Node 24.18.1 - #123
Merged
Merged
Conversation
Upgrade @playwright/test to 1.59.1 and pin shell.nix to a nixos-26.05 revision whose nodejs_24 is 24.18.1 and whose playwright-driver is 1.59.1, so nix-provided browsers match the npm package. The CI e2e job sets up Node from .node-version again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Playwright from 1.52.0 to 1.59.1, which lets the e2e environment use Node 24.18.1 like everything else. Before this change,
shell.nixand the CI e2e job ran an older Node, because Playwright 1.52 hangs while it loads its config on Node 24.18.1.How to verify
nix-shell --run 'node --version'printsv24.18.1.nix-shell --run 'bun install --frozen-lockfile' && bun run test:e2e.better-sqlite3NODE_MODULE_VERSIONmismatch, because the install and the test run now share one Node major..node-versionand passes.Version choices
shell.nixtakes browsers from nixpkgsplaywright-driver, and they must match the npm version. 1.59.1 is the newest release on the stablenixos-26.05channel, and 1.53+ fixes the hang. Getting 1.63 would mean either pinningnixos-unstableor building browser derivations by hand.02e0898(anixos-26.05Hydra eval from 2026-08-14). At that revisionnodejs_24is exactly 24.18.1 andplaywright-driveris 1.59.1, and both are in cache.nixos.org, so nothing builds from source. The currentnixos-26.05tip ships Node 24.21.0, and Node 24.19.0+ crashesbetter-sqlite3(nodejs/node#65446).chromium-1217, and that is the revision inPLAYWRIGHT_BROWSERS_PATH.Changes
apps/web/package.jsonandbun.lock:@playwright/test1.59.1.shell.nix: pinned to nixpkgsnixos-26.05rev02e0898.actions/setup-nodewith.node-versionagain. Browsers are still installed withbunx playwright install, which follows the npm version.docs/code/architecture.md: drops the Node exception for e2e.Verification
bun run test:e2ein the nix shell after a cleanbun installon Node 24.18.1: 17 passed.bun run format,bun run lint,bun run typecheck: pass.bun run test:web: 201 passed.