test(and_scalar): tag bitwise_and_scalar tests so pytest -m and_scalar collects - #6033
Merged
Merged
Conversation
bin913
requested review from
0x45f,
103yiran,
Caeruleann,
douxetpur,
hellojack163,
huangyiqun and
w1120029931-bit
as code owners
September 7, 2026 04:00
bin913
force-pushed
the
fix/5092-and-scalar-tests
branch
from
September 7, 2026 04:26
b0e92ae to
b44b672
Compare
…r collects Issue flagos-ai#5092: `pytest -m and_scalar --ref cpu` selected 0 tests because the and_scalar operator (__and__.Scalar) had no pytest marker anywhere in tests/, and conf/ci_test_aliases.yaml pointed at a non-existent tests/test_bitwise_and.py. The dunder op shares its implementation with the bitwise_and variants, so tag the existing bitwise_and_scalar test with @pytest.mark.and_scalar and repoint the alias at tests/test_bitwise_and_scalar.py. Closes flagos-ai#5092.
bin913
force-pushed
the
fix/5092-and-scalar-tests
branch
from
September 7, 2026 05:31
b44b672 to
864ecee
Compare
huangyiqun
approved these changes
Sep 7, 2026
huangyiqun
left a comment
huangyiqun
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The alias and marker now point to the existing scalar tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
OP Test
Type of Change
Description
Issue #5092:
pytest -m and_scalar --ref cpuselected 0 tests because theand_scalaroperator (__and__.Scalar) had no pytest marker anywhere intests/, andconf/ci_test_aliases.yamlpointed at a non-existenttests/test_bitwise_and.py.The dunder op shares its implementation with the bitwise_and variants, so tag the existing
bitwise_and_scalartest with@pytest.mark.and_scalarand repoint the alias attests/test_bitwise_and_scalar.py.Issue
Closes #5092
Progress
@pytest.mark.and_scalarto the bitwise_and_scalar testsand_scalaralias totest_bitwise_and_scalarTest Plan
python -m pytest -m and_scalar -svv --ref cpunow collects the bitwise_and_scalar cases instead of0 selected.