Repository navigation
Remove repository clutter: legacy JSmol demos, sample data, stale docs - #57
Merged
Merged
Conversation
…s and scripts Nothing here was part of the app. legacy/ (292 files, 14 MB) is the JSmol distribution's demo pages; jsmol/data/ (39 MB) is JSmol's sample data of which only caffeine.mol and buckyball.mol are loaded, and the whole directory went into every installer via jsmol/**/*; jsmol/js/JSmolJME.js lost its script tag in 1.5.5; the icon drafts are not used by generate-icons.sh; WINDOWS11-FIX-SUMMARY.md, VERSION-MANAGEMENT.md, build-version.js and debug-gpu.js are June 2025 leftovers whose content Troubleshooting.md covers. The check-version and debug-gpu npm scripts go with them; docs updated accordingly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are primarily deletions/cleanup with references updated, with only a minor changelog wording correction suggested.
Review effort: Lite
Findings: 1
What changed in this PR
This PR reduces repository and installer footprint by removing legacy/demo assets and outdated tooling/docs that were not part of the shipped application, while updating documentation and release notes to match the trimmed tree.
Changes:
- Deleted the
legacy/JSmol demo tree and prunedjsmol/data/down to the two sample molecules used by the UI. - Removed stale/unneeded scripts and docs (
debug-gpu.js,build-version.js, VERSION-MANAGEMENT/W11 leftovers) and theirpackage.jsonscript entries. - Updated
Troubleshooting.md, Copilot instructions, andCHANGELOG.mdto reflect the removals.
| File | Description |
|---|---|
package.json |
Removes debug-gpu and check-version npm scripts tied to deleted tooling. |
Troubleshooting.md |
Drops references to the removed GPU debug tool and removed “additional docs” links. |
CHANGELOG.md |
Adds a “Removed” entry documenting the cleanup (one sentence needs tightening per review comment). |
.github/copilot-instructions.md |
Updates internal instructions to stop referencing removed scripts/docs and reflects jsmol/data/ now only containing the two samples. |
VERSION-MANAGEMENT.md (deleted) |
Removes stale documentation for a removed verification script. |
build-version.js (deleted) |
Removes unused version-consistency checker previously invoked via npm script. |
build/icon_detailed.svg (deleted) |
Removes icon draft asset not used in the build. |
build/icon_benzene_simple.svg (deleted) |
Removes icon draft asset not used in the build. |
legacy/** (deleted, 292 files) |
Removes legacy JSmol demos/test pages not used by the app. |
jsmol/data/** (pruned) |
Removes bundled sample datasets to reduce installer size; keeps caffeine.mol and buckyball.mol. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| ### Removed | ||
|
|
||
| - Repository clutter that was never part of the app: the `legacy/` JSmol demo pages (292 files), JSmol's sample data in `jsmol/data/` except the two sample molecules the buttons load (39 MB, previously shipped in every installer), the unused `jsmol/js/JSmolJME.js`, the icon drafts `build/icon_benzene*.svg` and `build/icon_detailed.svg`, and the June 2025 leftovers `WINDOWS11-FIX-SUMMARY.md`, `VERSION-MANAGEMENT.md`, `build-version.js` (`npm run check-version`) and `debug-gpu.js` (`npm run debug-gpu`). `Troubleshooting.md` covers what those documents said. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
legacy/(292 JSmol demo files),jsmol/data/except the two sample molecules the buttons load (39 MB that went into every installer), the unusedjsmol/js/JSmolJME.js, the icon draftsbuild/icon_benzene*.svgandbuild/icon_detailed.svg, and the June 2025 leftoversWINDOWS11-FIX-SUMMARY.md,VERSION-MANAGEMENT.md,build-version.js,debug-gpu.jswith their npm scripts.CNAMEstays. Docs (Troubleshooting.md, copilot instructions) updated; CHANGELOG has a Removed entry.jsmolgoes from 95 MB to 57 MB; 444 files deleted.Test plan
npm run smokeand--bridge-probegreen on the trimmed tree (Linux, Xvfb).🤖 Generated with Claude Code