feature/exchange-gain-loss by fivetran-catfritz · Pull Request #215 · fivetran/dbt_quickbooks

fivetran-catfritz · 2026-06-26T17:44:55Z

PR Overview

Package version introduced in this PR:

v1.9.0-a1
v1.9.0

This PR addresses the following Issue/Feature(s):

GA-1026684

Summary of changes:

dds realized exchange gain/loss entries to int_quickbooks__bill_payment_double_entry and int_quickbooks__payment_double_entry to capture the currency impact when a foreign currency transaction is settled at a different exchange rate than when it was originally recorded. Requires an ExchangeGainOrLoss account in QuickBooks to generate entries.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention
Merge any relevant open PRs into this PR

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-savage

Just one question about the changelog but nothing to hold off approval for a pre-release.

fivetran-savage · 2026-06-30T19:59:03Z

+| `quickbooks__general_ledger`<br>`quickbooks__general_ledger_by_period` | New records | — | Exchange gain/loss entries | |
+
+## Feature Update
+- Adds realized exchange gain/loss entries to `int_quickbooks__bill_payment_double_entry` and `int_quickbooks__payment_double_entry` to capture the currency impact when a foreign currency transaction is settled at a different exchange rate than when it was originally recorded. Requires an `ExchangeGainOrLoss` account in QuickBooks to generate entries.


In the validation, it appears to be both an account_name value and an account_sub_type value. Do we need to call that out explicitly?

Good question. It's the account_sub_type that is a pre-set list coming from Quickbook, and the name should follow, so yes I should clarify what field we're talking about here.

fivetran-joemarkiewicz

A few change requests before approval. Let me know if you have any questions.

fivetran-joemarkiewicz · 2026-07-06T19:29:28Z

+
+## Feature Update
+- Adds realized exchange gain/loss entries to `int_quickbooks__bill_payment_double_entry` and `int_quickbooks__payment_double_entry` to capture the currency impact when a foreign currency transaction is settled at a different exchange rate than when it was originally recorded. Requires an account with a subtype of `ExchangeGainOrLoss` in QuickBooks to generate entries.
+- Adds the `using_exchange_gain_loss` variable (default `true`) to disable exchange gain/loss entry generation for users without multi-currency transactions or an Exchange Gain or Loss account. See the [README](https://github.com/fivetran/dbt_quickbooks/tree/main#disabling-exchange-gainloss-entries) for details.


Let's not set this a true by default to start. This is a major new accounting shift. While I agree this is necessary for users leveraging multi-currency and have an ExchangeGainOrLoss account, this may not be relevant for all users.

Let's set this as false by default and highlight the reason you would enable this and offer the configuration for those who need it or want to try it. We can plan to swap this to true in a future release once we have full confidence in it's behavior.

Given this approach, we'll need to update the various files where we set this as true by default and where we document the default behavior.

fivetran-catfritz

@fivetran-joemarkiewicz Thank you! Made the udpates.

fivetran-joemarkiewicz

LGTM with a few change suggestions. Also, be sure to change the merge branch to be the release branch.

fivetran-joemarkiewicz · 2026-07-07T14:18:35Z

+## Schema/Data Change
+**2 total changes • 0 possible breaking changes**
+
+| Data Model(s) | Change type | Old | New | Notes |
+| ------------- | ----------- | --- | --- | ----- |
+| `quickbooks__general_ledger`<br>`quickbooks__general_ledger_by_period` | New records | — | Exchange gain/loss entries | |


We should remove this since by default there's no schema/data change. The Feature Update section can highlight this.

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>

Updated the CHANGELOG to reflect changes in tax line models and potential breaking changes for users. Added details about enabling tax lines and configuration requirements.

Updated the CHANGELOG to reflect new features and updates regarding tax lines and exchange gain/loss entries.

@fivetran-catfritz

* version bump * Feature/remaining tax lines (#212) * Feature re: remaining tax lines * Resolve outstanding issues * Testing tax lines * Schema * Take out tax line variable, will bring in later * Changelog, docs * Generate dbt docs via GitHub Actions * Fix compilation error * table/table doc additions --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Tax lines on Quickstart * Revert seeds to main; replace new tax-line seeds with actionable joined data Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Revert seeds * update seed col types * Validation test fixes * dbt_project.yml * Generate dbt docs via GitHub Actions * New source relation * Apply suggestions from code review Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> * PR changes * Apply suggestions from code review Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> * PR requests * float64 casting * Apply suggestions from code review Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com> * CHANGELOG * CHANGELOG * feature/exchange-gain-loss (#215) * feature/exchange-gain-loss * fixes * decisionlog * yml * Apply suggestion from @fivetran-catfritz * ad some aliases * convert to full * Generate dbt docs via GitHub Actions * update vars * update docs * Generate dbt docs via GitHub Actions * Apply suggestions from code review Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com> * fix seed ids * fix seed dupes * put the seeds back * restore seeds again * restore seeds again * restore seeds again * update col seed types * Generate dbt docs via GitHub Actions * merge conflicts * Update CHANGELOG with tax line model changes Updated the CHANGELOG to reflect changes in tax line models and potential breaking changes for users. Added details about enabling tax lines and configuration requirements. * Update CHANGELOG.md * Revise CHANGELOG for new features and updates Updated the CHANGELOG to reflect new features and updates regarding tax lines and exchange gain/loss entries. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> * Generate dbt docs via GitHub Actions * Release final checks * Generate dbt docs via GitHub Actions * Changelog tweak * Generate dbt docs via GitHub Actions --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Catherine Fritz <111930712+fivetran-catfritz@users.noreply.github.com> Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>

feature/exchange-gain-loss

4832c88

fivetran-catfritz marked this pull request as draft June 26, 2026 17:45

fivetran-catfritz added 3 commits June 26, 2026 13:05

fixes

1b004fa

decisionlog

32a70b8

yml

94498cd

fivetran-catfritz self-assigned this Jun 30, 2026

fivetran-catfritz marked this pull request as ready for review June 30, 2026 19:08

Merge branch 'main' into feature/exchange-gain-loss

8458080

fivetran-savage approved these changes Jun 30, 2026

View reviewed changes

fivetran-catfritz commented Jun 30, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

Apply suggestion from @fivetran-catfritz

c67d3c5

fivetran-catfritz added the pre-release Triggers the auto-releaser workflow. label Jun 30, 2026

fivetran-catfritz added 2 commits July 6, 2026 10:04

ad some aliases

02d2ae2

convert to full

0546876

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed pre-release Triggers the auto-releaser workflow. labels Jul 6, 2026

Generate dbt docs via GitHub Actions

7d30d3e

fivetran-joemarkiewicz requested changes Jul 6, 2026

View reviewed changes

fivetran-catfritz added 2 commits July 6, 2026 16:15

update vars

ab37ec4

update docs

76d1595

fivetran-catfritz added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 6, 2026

fivetran-catfritz commented Jul 6, 2026

View reviewed changes

Comment thread models/double_entry_transactions/int_quickbooks__bill_payment_double_entry.sql

Comment thread models/double_entry_transactions/int_quickbooks__payment_double_entry.sql

Generate dbt docs via GitHub Actions

288ff86

fivetran-joemarkiewicz approved these changes Jul 7, 2026

View reviewed changes

fivetran-catfritz commented Jul 7, 2026

View reviewed changes

Comment thread DECISIONLOG.md Outdated

Apply suggestions from code review

8a527f9

Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: fivetran-catfritz <111930712+fivetran-catfritz@users.noreply.github.com>

fivetran-catfritz changed the base branch from main to release/1.9.0 July 7, 2026 15:03

fivetran-catfritz added 2 commits July 7, 2026 10:19

resolve conflicts

22f70ee

fix seed ids

dcd1f37

fivetran-catfritz added 7 commits July 7, 2026 11:24

fix seed dupes

a0b989d

put the seeds back

052720a

Merge branch 'release/1.9.0' into feature/exchange-gain-loss

1901141

restore seeds again

19dace7

restore seeds again

6ec394d

restore seeds again

cad79f2

update col seed types

66c07c7

fivetran-avinash added docs:ready Triggers the docs generator workflow. and removed docs:ready Triggers the docs generator workflow. labels Jul 8, 2026

github-actions Bot and others added 8 commits July 8, 2026 08:53

Generate dbt docs via GitHub Actions

25070ea

merge conflicts

075a53f

merge conflicts

eab7a5a

Merge branch 'release/1.9.0' into feature/exchange-gain-loss

89629a6

Merge branch 'release/1.9.0' into feature/exchange-gain-loss

8e671ea

Update CHANGELOG with tax line model changes

dcac347

Updated the CHANGELOG to reflect changes in tax line models and potential breaking changes for users. Added details about enabling tax lines and configuration requirements.

Update CHANGELOG.md

5e32fc2

Revise CHANGELOG for new features and updates

6b11c81

Updated the CHANGELOG to reflect new features and updates regarding tax lines and exchange gain/loss entries.

fivetran-catfritz merged commit 04defae into release/1.9.0 Jul 11, 2026
2 of 9 checks passed

Uh oh!

Conversation

fivetran-catfritz commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-savage left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-savage Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fivetran-joemarkiewicz Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-joemarkiewicz Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fivetran-joemarkiewicz Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

fivetran-catfritz Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fivetran-catfritz commented Jun 26, 2026 •

edited

Loading

fivetran-catfritz Jun 30, 2026 •

edited

Loading