Repository navigation
FCE-3912 Keep iOS call audio working after audio-session changes and CallKit hold - #617
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused removal matches the linked native hold-handling contract, with no unresolved findings in the reviewed change.
No open issues 🎉
What changed in this PR
Removes fishjam-chat’s JavaScript hold handler so native CallKit handling can preserve iOS call audio across hold and resume, consistent with the linked native fix.
Changes:
- Removes microphone stop/start calls on
heldevents, avoiding creation of an unpublished microphone track on resume. - Leaves hold-related audio control to the native implementation.
| File | Description |
|---|---|
examples/mobile-client/fishjam-chat/app/room/[roomName].tsx |
Removes the JavaScript CallKit hold handler. |
Review effort: Balanced
czerwiukk
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
react-native-webrtcto iOS: keep call audio after audio session changes and CallKit hold fishjam-react-native-webrtc#102:FishjamWebRTC124.0.2.4 restarts the audio unit when something else stops it, andCallKitManagerswitches WebRTC audio off while a CallKit call is held.heldhandler, which calledstopMicrophone()on hold andstartMicrophone()on resume.Motivation and Context
Fixes iOS call audio going silent after another library deactivates the audio session, or after a CallKit call is held and resumed.
The
heldhandler broke resume on its own:startMicrophone()creates a new track but doesn't publish it, so the other side heard silence after the call was resumed. Hold is now handled natively.Documentation impact
Types of changes
not work as expected)